From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90C95C31E40 for ; Tue, 6 Aug 2019 10:23:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B10C20C01 for ; Tue, 6 Aug 2019 10:23:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B10C20C01 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60102 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1huwdJ-0000IT-Md for qemu-devel@archiver.kernel.org; Tue, 06 Aug 2019 06:23:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42095) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1huwcv-0008B7-9k for qemu-devel@nongnu.org; Tue, 06 Aug 2019 06:23:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1huwcu-0008SQ-8l for qemu-devel@nongnu.org; Tue, 06 Aug 2019 06:23:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58362) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1huwcu-0008S8-3Z for qemu-devel@nongnu.org; Tue, 06 Aug 2019 06:23:32 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5753D30EA1A7; Tue, 6 Aug 2019 10:23:31 +0000 (UTC) Received: from work-vm (ovpn-117-206.ams2.redhat.com [10.36.117.206]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7D4285C1B5; Tue, 6 Aug 2019 10:23:30 +0000 (UTC) Date: Tue, 6 Aug 2019 11:23:28 +0100 From: "Dr. David Alan Gilbert" To: Wei Yang Message-ID: <20190806102328.GE3066@work-vm> References: <20190806003645.8426-1-richardw.yang@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190806003645.8426-1-richardw.yang@linux.intel.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Tue, 06 Aug 2019 10:23:31 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH v3] hmp: Remove migration capabilities from "info migrate" X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, armbru@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Wei Yang (richardw.yang@linux.intel.com) wrote: > With the growth of migration capabilities, it is not proper to display > them in "info migrate". Users are recommended to use "info > migrate_capabiltiies" to list them. > > Signed-off-by: Wei Yang > Suggested-by: Dr. David Alan Gilbert Reviewed-by: Dr. David Alan Gilbert > > --- > v3: > * remove un-used variable caps > v2: > * remove capabilities from "info migrate" > --- > monitor/hmp-cmds.c | 14 -------------- > 1 file changed, 14 deletions(-) > > diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c > index 5ca3ebe942..35788c0645 100644 > --- a/monitor/hmp-cmds.c > +++ b/monitor/hmp-cmds.c > @@ -220,24 +220,11 @@ static char *SocketAddress_to_str(SocketAddress *addr) > void hmp_info_migrate(Monitor *mon, const QDict *qdict) > { > MigrationInfo *info; > - MigrationCapabilityStatusList *caps, *cap; > > info = qmp_query_migrate(NULL); > - caps = qmp_query_migrate_capabilities(NULL); > > migration_global_dump(mon); > > - /* do not display parameters during setup */ > - if (info->has_status && caps) { > - monitor_printf(mon, "capabilities: "); > - for (cap = caps; cap; cap = cap->next) { > - monitor_printf(mon, "%s: %s ", > - MigrationCapability_str(cap->value->capability), > - cap->value->state ? "on" : "off"); > - } > - monitor_printf(mon, "\n"); > - } > - > if (info->has_status) { > monitor_printf(mon, "Migration status: %s", > MigrationStatus_str(info->status)); > @@ -370,7 +357,6 @@ void hmp_info_migrate(Monitor *mon, const QDict *qdict) > monitor_printf(mon, "]\n"); > } > qapi_free_MigrationInfo(info); > - qapi_free_MigrationCapabilityStatusList(caps); > } > > void hmp_info_migrate_capabilities(Monitor *mon, const QDict *qdict) > -- > 2.17.1 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK