From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18453C433FF for ; Wed, 7 Aug 2019 17:31:41 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E275121E70 for ; Wed, 7 Aug 2019 17:31:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E275121E70 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43850 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hvPmm-0008HR-9H for qemu-devel@archiver.kernel.org; Wed, 07 Aug 2019 13:31:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55412) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hvPmO-0007q0-0C for qemu-devel@nongnu.org; Wed, 07 Aug 2019 13:31:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hvPmM-0001VQ-47 for qemu-devel@nongnu.org; Wed, 07 Aug 2019 13:31:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49828) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hvPmL-0001Rl-Hm for qemu-devel@nongnu.org; Wed, 07 Aug 2019 13:31:14 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 87D64550BB; Wed, 7 Aug 2019 17:31:11 +0000 (UTC) Received: from work-vm (ovpn-117-204.ams2.redhat.com [10.36.117.204]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A902D600C6; Wed, 7 Aug 2019 17:31:10 +0000 (UTC) Date: Wed, 7 Aug 2019 18:31:08 +0100 From: "Dr. David Alan Gilbert" To: Wei Yang Message-ID: <20190807173108.GF27871@work-vm> References: <20190709140924.13291-1-richardw.yang@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190709140924.13291-1-richardw.yang@linux.intel.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Wed, 07 Aug 2019 17:31:11 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH 0/3] migration/savevm: move non SaveStateEntry condition check out of iteration X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, quintela@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Wei Yang (richardw.yang@linux.intel.com) wrote: > qemu_savevm_state_complete_precopy() iterates SaveStateEntry and does proper > tasks for migration. > > For each iteration, in_postcopy and iterable_only would be checked to see > whether it should skip. Since these two conditions are not SaveStateEntry > specific, it is proper to move the check out of iteration. > > These three patches prepare the code and move the condition check out of the > iteration. > Queued > > Wei Yang (3): > migration/savevm: flush file for iterable_only case > migration/savevm: split qemu_savevm_state_complete_precopy() into two > parts > migration/savevm: move non SaveStateEntry condition check out of > iteration > > migration/savevm.c | 68 ++++++++++++++++++++++++++++++++++------------ > 1 file changed, 50 insertions(+), 18 deletions(-) > > -- > 2.17.1 > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK