From: Wei Yang <richardw.yang@linux.intel.com>
To: qemu-devel@nongnu.org, berrange@redhat.com, dgilbert@redhat.com,
marcandre.lureau@redhat.com
Subject: [Qemu-devel] [Fail] tests/test-util-filemonitor fails
Date: Thu, 8 Aug 2019 10:07:23 +0800 [thread overview]
Message-ID: <20190808020723.GB26938@richard> (raw)
Current qemu fails tests/test-util-filemonitor.
By bisect, it shows this commit introduced the error.
commit ff3dc8fefe953fd3650279e064bf63b212c5699a
Author: Daniel P. Berrang茅 <berrange@redhat.com>
Date: Wed Mar 13 17:36:18 2019 +0000
filemon: ensure watch IDs are unique to QFileMonitor scope
The watch IDs are mistakenly only unique within the scope of the
directory being monitored. This is not useful for clients which are
monitoring multiple directories. They require watch IDs to be unique
globally within the QFileMonitor scope.
After revert
"filemon: ensure watch IDs are unique to QFileMonitor scope"
"filemon: fix watch IDs to avoid potential wraparound issues"
The test pass.
--
Wei Yang
Help you, Help me
next reply other threads:[~2019-08-08 2:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 2:07 Wei Yang [this message]
2019-08-08 8:02 ` [Qemu-devel] [Fail] tests/test-util-filemonitor fails Daniel P. Berrangé
2019-08-08 8:46 ` Wei Yang
2019-08-08 9:22 ` Daniel P. Berrangé
2019-08-09 0:06 ` Wei Yang
2019-08-09 9:12 ` Daniel P. Berrangé
2019-08-12 0:49 ` Wei Yang
2019-11-04 19:35 ` Miguel Arruga Vivas
2019-11-05 9:54 ` Daniel P. Berrangé
2019-11-08 8:52 ` Miguel Arruga Vivas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190808020723.GB26938@richard \
--to=richardw.yang@linux.intel.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).