From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=FROM_EXCESS_BASE64, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D772FC0650F for ; Thu, 8 Aug 2019 10:53:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6C2362184E for ; Thu, 8 Aug 2019 10:53:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6C2362184E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48344 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hvg3Q-0006HS-Gq for qemu-devel@archiver.kernel.org; Thu, 08 Aug 2019 06:53:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38513) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hvg2v-0005rc-Lh for qemu-devel@nongnu.org; Thu, 08 Aug 2019 06:53:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hvg2u-0006rK-Kj for qemu-devel@nongnu.org; Thu, 08 Aug 2019 06:53:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45814) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hvg2u-0006qs-F3 for qemu-devel@nongnu.org; Thu, 08 Aug 2019 06:53:24 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AF0B53006BB6; Thu, 8 Aug 2019 10:53:23 +0000 (UTC) Received: from redhat.com (ovpn-112-28.ams2.redhat.com [10.36.112.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A6B1A608A5; Thu, 8 Aug 2019 10:53:10 +0000 (UTC) Date: Thu, 8 Aug 2019 11:53:07 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Stefan Hajnoczi Message-ID: <20190808105307.GE2534@redhat.com> References: <20190807071445.4109-1-bala24@linux.ibm.com> <20190807071445.4109-2-bala24@linux.ibm.com> <5839fa4e-b6f3-9547-e71d-50be75c4f9fc@redhat.com> <20190808101013.GD1999@stefanha-x1.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190808101013.GD1999@stefanha-x1.localdomain> User-Agent: Mutt/1.12.0 (2019-05-25) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Thu, 08 Aug 2019 10:53:23 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [RFC PATCH 1/6] utils/python_api: add scripting interface for Qemu with python lib X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Peter Maydell , maddy@linux.vnet.ibm.com, qemu-devel@nongnu.org, Balamuruhan S , anju@linux.vnet.ibm.com, clg@kaod.org, Stefan Hajnoczi , hari@linux.vnet.ibm.com, pbonzini@redhat.com, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Aug 08, 2019 at 11:10:13AM +0100, Stefan Hajnoczi wrote: > On Wed, Aug 07, 2019 at 12:20:47PM +0200, Philippe Mathieu-Daud=C3=A9 w= rote: > > > +void python_args_clean(char *args[], int nargs) > > > +{ > > > + for (int i =3D 0; i < nargs; i++) { > > > + g_free(args[i]); > > > + } > > > +} > > >=20 > >=20 > > Wondering about security, is this feature safe to enable in productio= n > > environment? It seems to bypass all the hard effort to harden QEMU se= curity. >=20 > This seems like a feature that distros would not enable. Only users > building QEMU from source could enable it. Well that's true when this scripting is only used from one obscure ppc device. Once merged though, its inevitable that people will want to extend scripting to more & more parts of QEMU code. This is a big can of worms... Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberran= ge :| |: https://libvirt.org -o- https://fstop138.berrange.c= om :| |: https://entangle-photo.org -o- https://www.instagram.com/dberran= ge :|