From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Wei Yang <richardw.yang@linux.intel.com>
Cc: qemu-devel@nongnu.org, quintela@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3] migration/postcopy: use mis->bh instead of allocating a QEMUBH
Date: Thu, 8 Aug 2019 18:44:44 +0100 [thread overview]
Message-ID: <20190808174444.GN2852@work-vm> (raw)
In-Reply-To: <20190808020231.GA26938@richard>
* Wei Yang (richardw.yang@linux.intel.com) wrote:
> On Wed, Aug 07, 2019 at 07:35:34PM +0100, Dr. David Alan Gilbert wrote:
> >* Wei Yang (richardw.yang@linux.intel.com) wrote:
> >> For migration incoming side, it either quit in precopy or postcopy. It
> >> is safe to use the mis->bh for both instead of allocating a dedicated
> >> QEMUBH for postcopy.
> >>
> >> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
> >> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> >
> >Hi Wei,
> > Can you check this, the patchew tests came back with a failure which
> >seems bh related; I've not tried it, but can you just see if you can
> >reproduce it?
> >
>
> I tried make check, which looks good.
>
> (Some other upstream commit introduced error. I revert them to make check work)
OK, I'll pick it up and see how we go.
Dave
>
> >Dave
> >
>
> --
> Wei Yang
> Help you, Help me
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
prev parent reply other threads:[~2019-08-08 17:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-05 5:31 [Qemu-devel] [PATCH v3] migration/postcopy: use mis->bh instead of allocating a QEMUBH Wei Yang
2019-08-05 6:35 ` no-reply
2019-08-07 18:35 ` Dr. David Alan Gilbert
2019-08-08 0:59 ` Wei Yang
2019-08-08 2:02 ` Wei Yang
2019-08-08 17:44 ` Dr. David Alan Gilbert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190808174444.GN2852@work-vm \
--to=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=richardw.yang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).