From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "David Hildenbrand" <david@redhat.com>,
"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
"Cornelia Huck" <cohuck@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
armbru@redhat.com,
"open list:S390 general arch..." <qemu-s390x@nongnu.org>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Guan Xuetao" <gxt@mprc.pku.edu.cn>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Richard Henderson" <rth@twiddle.net>
Subject: [Qemu-devel] [PATCH v2 7/7] targets (various): use softfloat-helpers.h where we can
Date: Fri, 9 Aug 2019 10:19:40 +0100 [thread overview]
Message-ID: <20190809091940.1223-8-alex.bennee@linaro.org> (raw)
In-Reply-To: <20190809091940.1223-1-alex.bennee@linaro.org>
Generally the cpu and non-FP helper files just want to manipulate the
softfloat flags. For this they can just use the -helpers.h include
which brings in a minimal number of inline helpers.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
---
target/alpha/helper.c | 2 +-
target/microblaze/cpu.c | 2 +-
target/s390x/cpu.c | 2 +-
target/sh4/cpu.c | 3 +--
target/tricore/helper.c | 2 +-
target/unicore32/cpu.c | 1 -
6 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/target/alpha/helper.c b/target/alpha/helper.c
index 93b8e788b18..c6998348df4 100644
--- a/target/alpha/helper.c
+++ b/target/alpha/helper.c
@@ -21,7 +21,7 @@
#include "cpu.h"
#include "exec/exec-all.h"
-#include "fpu/softfloat.h"
+#include "fpu/softfloat-types.h"
#include "exec/helper-proto.h"
#include "qemu/qemu-print.h"
diff --git a/target/microblaze/cpu.c b/target/microblaze/cpu.c
index 0bec54b2f8a..9cfd7445e7d 100644
--- a/target/microblaze/cpu.c
+++ b/target/microblaze/cpu.c
@@ -28,7 +28,7 @@
#include "hw/qdev-properties.h"
#include "migration/vmstate.h"
#include "exec/exec-all.h"
-#include "fpu/softfloat.h"
+#include "fpu/softfloat-helpers.h"
static const struct {
const char *name;
diff --git a/target/s390x/cpu.c b/target/s390x/cpu.c
index 736a7903e22..5db016672bb 100644
--- a/target/s390x/cpu.c
+++ b/target/s390x/cpu.c
@@ -42,7 +42,7 @@
#include "sysemu/sysemu.h"
#include "sysemu/tcg.h"
#endif
-#include "fpu/softfloat.h"
+#include "fpu/softfloat-helpers.h"
#define CR0_RESET 0xE0UL
#define CR14_RESET 0xC2000000UL;
diff --git a/target/sh4/cpu.c b/target/sh4/cpu.c
index 816d6d7f311..d0a7707991f 100644
--- a/target/sh4/cpu.c
+++ b/target/sh4/cpu.c
@@ -25,8 +25,7 @@
#include "cpu.h"
#include "migration/vmstate.h"
#include "exec/exec-all.h"
-#include "fpu/softfloat.h"
-
+#include "fpu/softfloat-helpers.h"
static void superh_cpu_set_pc(CPUState *cs, vaddr value)
{
diff --git a/target/tricore/helper.c b/target/tricore/helper.c
index a6803368506..d5db7b2c03f 100644
--- a/target/tricore/helper.c
+++ b/target/tricore/helper.c
@@ -19,7 +19,7 @@
#include "cpu.h"
#include "exec/exec-all.h"
-#include "fpu/softfloat.h"
+#include "fpu/softfloat-helpers.h"
#include "qemu/qemu-print.h"
enum {
diff --git a/target/unicore32/cpu.c b/target/unicore32/cpu.c
index 802e2f1eba5..b27fb9689ff 100644
--- a/target/unicore32/cpu.c
+++ b/target/unicore32/cpu.c
@@ -17,7 +17,6 @@
#include "cpu.h"
#include "migration/vmstate.h"
#include "exec/exec-all.h"
-#include "fpu/softfloat.h"
static void uc32_cpu_set_pc(CPUState *cs, vaddr value)
{
--
2.20.1
next prev parent reply other threads:[~2019-08-09 9:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 9:19 [Qemu-devel] [PATCH v2 0/7] softfloat includes cleanup Alex Bennée
2019-08-09 9:19 ` [Qemu-devel] [PATCH v2 1/7] fpu: move LIT64 helper to softfloat-types Alex Bennée
2019-08-09 9:19 ` [Qemu-devel] [PATCH v2 2/7] fpu: move inline helpers into a separate header Alex Bennée
2019-08-09 9:19 ` [Qemu-devel] [PATCH v2 3/7] fpu: make softfloat-macros "self-contained" Alex Bennée
2019-08-09 9:19 ` [Qemu-devel] [PATCH v2 4/7] fpu: rename softfloat-specialize.h -> .inc.c Alex Bennée
2019-08-09 9:19 ` [Qemu-devel] [PATCH v2 5/7] target/mips: rationalise softfloat includes Alex Bennée
2019-08-09 10:20 ` Aleksandar Markovic
2019-08-09 9:19 ` [Qemu-devel] [PATCH v2 6/7] target/riscv: " Alex Bennée
2019-08-10 1:55 ` Alistair Francis
2019-08-13 23:30 ` Palmer Dabbelt
2019-08-14 9:19 ` Alex Bennée
2019-08-09 9:19 ` Alex Bennée [this message]
2019-08-09 9:34 ` [Qemu-devel] [PATCH v2 0/7] softfloat includes cleanup Philippe Mathieu-Daudé
2019-08-09 9:36 ` no-reply
2019-08-09 9:47 ` no-reply
2019-08-09 10:00 ` no-reply
2019-08-09 10:13 ` no-reply
2019-08-09 10:34 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190809091940.1223-8-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=aurelien@aurel32.net \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=edgar.iglesias@gmail.com \
--cc=gxt@mprc.pku.edu.cn \
--cc=kbastian@mail.uni-paderborn.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).