From: Stefan Hajnoczi <stefanha@gmail.com>
To: Ning Bo <ning.bo9@zte.com.cn>
Cc: mst@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2] vhost-vsock: report QMP event when set running
Date: Fri, 9 Aug 2019 14:41:34 +0100 [thread overview]
Message-ID: <20190809134134.GA8594@stefanha-x1.localdomain> (raw)
In-Reply-To: <1564975951-29263-1-git-send-email-ning.bo9@zte.com.cn>
[-- Attachment #1: Type: text/plain, Size: 1019 bytes --]
On Mon, Aug 05, 2019 at 11:32:31AM +0800, Ning Bo wrote:
> If a program in host communicates with a vsock device in guest via
> 'vsock://', but the device is not ready, the 'connect' syscall will
> block and then timeout after 2 second default.(the timeout is defined
> in kernel: #define VSOCK_DEFAULT_CONNECT_TIMEOUT (2 * HZ)).
> We can avoid this case if qemu reports an event when the vsock is
> ready and the program waits the event before connecting.
>
> Report vsock running event so that the upper application can
> control boot sequence.
> see https://github.com/kata-containers/runtime/pull/1918
Please describe the issue with connect(2) in detail. Are you observing
that connect(2) always times out when called before the guest driver
hasn't set the virtio-vsock status register to
VIRTIO_CONFIG_S_DRIVER_OK?
I think that adding a QMP event is working around the issue rather than
fixing the root cause. This is probably a vhost_vsock.ko problem and
should be fixed there.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-08-09 13:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-05 3:32 [Qemu-devel] [PATCH v2] vhost-vsock: report QMP event when set running Ning Bo
2019-08-09 13:41 ` Stefan Hajnoczi [this message]
2019-11-28 11:26 ` Re:[Qemu-devel] [PATCH v2] vhost-vsock: report QMP event when setrunning ning.bo9
2019-12-12 11:05 ` [Qemu-devel] " Stefan Hajnoczi
2019-12-12 11:24 ` Michael S. Tsirkin
2019-12-19 11:18 ` Stefan Hajnoczi
2019-12-13 7:11 ` Re:[Qemu-devel] [PATCH v2] vhost-vsock: report QMP event whensetrunning ning.bo9
2019-12-19 11:35 ` [Qemu-devel] " Stefan Hajnoczi
2019-12-20 2:38 ` Re:[Qemu-devel] [PATCH v2] vhost-vsock: report QMP eventwhensetrunning ning.bo9
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190809134134.GA8594@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=armbru@redhat.com \
--cc=mst@redhat.com \
--cc=ning.bo9@zte.com.cn \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).