From: Jan Bobek <jan.bobek@gmail.com>
To: qemu-devel@nongnu.org
Cc: "Jan Bobek" <jan.bobek@gmail.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>
Subject: [Qemu-devel] [RFC PATCH v2 23/39] target/i386: introduce instruction translator macros
Date: Sat, 10 Aug 2019 00:12:39 -0400 [thread overview]
Message-ID: <20190810041255.6820-24-jan.bobek@gmail.com> (raw)
In-Reply-To: <20190810041255.6820-1-jan.bobek@gmail.com>
Instruction "translators" are responsible for decoding and loading
instruction operands, calling the passed-in code generator, and
storing the operands back (if applicable). Once a translator returns,
the instruction has been translated to TCG ops, hence the name.
Signed-off-by: Jan Bobek <jan.bobek@gmail.com>
---
target/i386/translate.c | 288 ++++++++++++++++++++++++++++++++++++++++
1 file changed, 288 insertions(+)
diff --git a/target/i386/translate.c b/target/i386/translate.c
index 30180d1c25..0da064d5fd 100644
--- a/target/i386/translate.c
+++ b/target/i386/translate.c
@@ -4715,6 +4715,222 @@ static int ck_cpuid(CPUX86State *env, DisasContext *s, int ck_cpuid_feat)
#define gen_insn_wrrr(mnem, opW1, opR1, opR2, opR3) \
gen_ ## mnem ## _ ## opW1 ## opR1 ## opR2 ## opR3
+/*
+ * Instruction translators
+ */
+#define translate_insn_r(opR1) \
+ translate_insn_r_ ## opR1
+#define translate_insn_rr(opR1, opR2) \
+ translate_insn_rr_ ## opR1 ## opR2
+#define translate_insn_w(opW1) \
+ translate_insn_w_ ## opW1
+#define translate_insn_wr(opW1, opR1) \
+ translate_insn_wr_ ## opW1 ## opR1
+#define translate_insn_wrr(opW1, opR1, opR2) \
+ translate_insn_wrr_ ## opW1 ## opR1 ## opR2
+#define translate_insn_wrrr(opW1, opR1, opR2, opR3) \
+ translate_insn_wrrr_ ## opW1 ## opR1 ## opR2 ## opR3
+#define translate_group(grpname) \
+ translate_group_ ## grpname
+
+static void translate_insn(
+ CPUX86State *env, DisasContext *s, int ck_cpuid_feat,
+ void (*gen_insn_fp)(CPUX86State *, DisasContext *))
+{
+ if (ck_cpuid(env, s, ck_cpuid_feat)) {
+ gen_illegal_opcode(s);
+ return;
+ }
+
+ (*gen_insn_fp)(env, s);
+}
+
+#define TRANSLATE_INSN_R(opR1) \
+ static void translate_insn_r(opR1)( \
+ CPUX86State *env, DisasContext *s, int modrm, int ck_cpuid_feat, \
+ void (*gen_insn_fp)(CPUX86State *, DisasContext *, insnop_t(opR1))) \
+ { \
+ insnop_t(opR1) arg1; \
+ \
+ if (ck_cpuid(env, s, ck_cpuid_feat) \
+ || insnop_init(opR1)(env, s, modrm, &arg1)) { \
+ gen_illegal_opcode(s); \
+ return; \
+ } \
+ \
+ insnop_prepare(opR1)(env, s, modrm, &arg1); \
+ (*gen_insn_fp)(env, s, arg1); \
+ }
+
+#define TRANSLATE_INSN_RR(opR1, opR2) \
+ static void translate_insn_rr(opR1, opR2)( \
+ CPUX86State *env, DisasContext *s, int modrm, int ck_cpuid_feat, \
+ void (*gen_insn_fp)(CPUX86State *, DisasContext *, insnop_t(opR1), \
+ insnop_t(opR2))) \
+ { \
+ insnop_t(opR1) arg1; \
+ insnop_t(opR2) arg2; \
+ \
+ if (ck_cpuid(env, s, ck_cpuid_feat) \
+ || insnop_init(opR1)(env, s, modrm, &arg1) \
+ || insnop_init(opR2)(env, s, modrm, &arg2)) { \
+ gen_illegal_opcode(s); \
+ return; \
+ } \
+ \
+ insnop_prepare(opR1)(env, s, modrm, &arg1); \
+ insnop_prepare(opR2)(env, s, modrm, &arg2); \
+ (*gen_insn_fp)(env, s, arg1, arg2); \
+ }
+
+#define TRANSLATE_INSN_W(opW1) \
+ static void translate_insn_w(opW1)( \
+ CPUX86State *env, DisasContext *s, int modrm, int ck_cpuid_feat, \
+ void (*gen_insn_fp)(CPUX86State *, DisasContext *, insnop_t(opW1))) \
+ { \
+ insnop_t(opW1) ret; \
+ \
+ if (ck_cpuid(env, s, ck_cpuid_feat) \
+ || insnop_init(opW1)(env, s, modrm, &ret)) { \
+ gen_illegal_opcode(s); \
+ return; \
+ } \
+ \
+ (*gen_insn_fp)(env, s, ret); \
+ insnop_finalize(opW1)(env, s, modrm, &ret); \
+ }
+
+#define TRANSLATE_INSN_WR(opW1, opR1) \
+ static void translate_insn_wr(opW1, opR1)( \
+ CPUX86State *env, DisasContext *s, int modrm, int ck_cpuid_feat, \
+ void (*gen_insn_fp)(CPUX86State *, DisasContext *, insnop_t(opW1), \
+ insnop_t(opR1))) \
+ { \
+ insnop_t(opW1) ret; \
+ insnop_t(opR1) arg1; \
+ \
+ if (ck_cpuid(env, s, ck_cpuid_feat) \
+ || insnop_init(opW1)(env, s, modrm, &ret) \
+ || insnop_init(opR1)(env, s, modrm, &arg1)) { \
+ gen_illegal_opcode(s); \
+ return; \
+ } \
+ \
+ insnop_prepare(opR1)(env, s, modrm, &arg1); \
+ (*gen_insn_fp)(env, s, ret, arg1); \
+ insnop_finalize(opW1)(env, s, modrm, &ret); \
+ }
+
+#define TRANSLATE_INSN_WRR(opW1, opR1, opR2) \
+ static void translate_insn_wrr(opW1, opR1, opR2)( \
+ CPUX86State *env, DisasContext *s, int modrm, int ck_cpuid_feat, \
+ void (*gen_insn_fp)(CPUX86State *, DisasContext *, insnop_t(opW1), \
+ insnop_t(opR1), insnop_t(opR2))) \
+ { \
+ insnop_t(opW1) ret; \
+ insnop_t(opR1) arg1; \
+ insnop_t(opR2) arg2; \
+ \
+ if (ck_cpuid(env, s, ck_cpuid_feat) \
+ || insnop_init(opW1)(env, s, modrm, &ret) \
+ || insnop_init(opR1)(env, s, modrm, &arg1) \
+ || insnop_init(opR2)(env, s, modrm, &arg2)) { \
+ gen_illegal_opcode(s); \
+ return; \
+ } \
+ \
+ insnop_prepare(opR1)(env, s, modrm, &arg1); \
+ insnop_prepare(opR2)(env, s, modrm, &arg2); \
+ (*gen_insn_fp)(env, s, ret, arg1, arg2); \
+ insnop_finalize(opW1)(env, s, modrm, &ret); \
+ }
+
+#define TRANSLATE_INSN_WRRR(opW1, opR1, opR2, opR3) \
+ static void translate_insn_wrrr(opW1, opR1, opR2, opR3)( \
+ CPUX86State *env, DisasContext *s, int modrm, int ck_cpuid_feat, \
+ void (*gen_insn_fp)(CPUX86State *, DisasContext *, insnop_t(opW1), \
+ insnop_t(opR1), insnop_t(opR2), insnop_t(opR3))) \
+ { \
+ insnop_t(opW1) ret; \
+ insnop_t(opR1) arg1; \
+ insnop_t(opR2) arg2; \
+ insnop_t(opR3) arg3; \
+ \
+ if (ck_cpuid(env, s, ck_cpuid_feat) \
+ || insnop_init(opW1)(env, s, modrm, &ret) \
+ || insnop_init(opR1)(env, s, modrm, &arg1) \
+ || insnop_init(opR2)(env, s, modrm, &arg2) \
+ || insnop_init(opR3)(env, s, modrm, &arg3)) { \
+ gen_illegal_opcode(s); \
+ return; \
+ } \
+ \
+ insnop_prepare(opR1)(env, s, modrm, &arg1); \
+ insnop_prepare(opR2)(env, s, modrm, &arg2); \
+ insnop_prepare(opR3)(env, s, modrm, &arg3); \
+ (*gen_insn_fp)(env, s, ret, arg1, arg2, arg3); \
+ insnop_finalize(opW1)(env, s, modrm, &ret); \
+ }
+
+#define INSN_GRP_BEGIN(grpname) \
+ static void translate_group(grpname)( \
+ CPUX86State *env, DisasContext *s, int modrm) \
+ { \
+ const int reg = decode_modrm_reg_norexr(env, s, modrm); \
+ \
+ switch (reg) {
+#define INSN_GRPMEMB(grpname, mnem, opcode, feat) \
+ case opcode: \
+ translate_insn( \
+ env, s, CK_CPUID_ ## feat, \
+ gen_insn(mnem)); \
+ return;
+#define INSN_GRPMEMB_R(grpname, mnem, opcode, feat, opR1) \
+ case opcode: \
+ translate_insn_r(opR1)( \
+ env, s, modrm, CK_CPUID_ ## feat, \
+ gen_insn_r(mnem, opR1)); \
+ return;
+#define INSN_GRPMEMB_RR(grpname, mnem, opcode, feat, opR1, opR2) \
+ case opcode: \
+ translate_insn_rr(opR1, opR2)( \
+ env, s, modrm, CK_CPUID_ ## feat, \
+ gen_insn_rr(mnem, opR1, opR2)); \
+ return;
+#define INSN_GRPMEMB_W(grpname, mnem, opcode, feat, opW1) \
+ case opcode: \
+ translate_insn_w(opW1)( \
+ env, s, modrm, CK_CPUID_ ## feat, \
+ gen_insn_w(mnem, opW1)); \
+ return;
+#define INSN_GRPMEMB_WR(grpname, mnem, opcode, feat, opW1, opR1) \
+ case opcode: \
+ translate_insn_wr(opW1, opR1)( \
+ env, s, modrm, CK_CPUID_ ## feat, \
+ gen_insn_wr(mnem, opW1, opR1)); \
+ return;
+#define INSN_GRPMEMB_WRR(grpname, mnem, opcode, feat, opW1, opR1, opR2) \
+ case opcode: \
+ translate_insn_wrr(opW1, opR1, opR2)( \
+ env, s, modrm, CK_CPUID_ ## feat, \
+ gen_insn_wrr(mnem, opW1, opR1, opR2)); \
+ return;
+#define INSN_GRPMEMB_WRRR(grpname, mnem, opcode, feat, opW1, opR1, opR2, opR3) \
+ case opcode: \
+ translate_insn_wrrr(opW1, opR1, opR2, opR3)( \
+ env, s, modrm, CK_CPUID_ ## feat, \
+ gen_insn_wrrr(mnem, opW1, opR1, opR2, opR3)); \
+ return;
+#define INSN_GRP_END(grpname) \
+ default: \
+ gen_illegal_opcode(s); \
+ return; \
+ } \
+ \
+ g_assert_not_reached(); \
+ }
+#include "insn.h"
+
static void gen_sse_ng(CPUX86State *env, DisasContext *s, int b)
{
enum {
@@ -4726,15 +4942,87 @@ static void gen_sse_ng(CPUX86State *env, DisasContext *s, int b)
M_0F = 1 << (4 + 8),
};
+ int modrm;
+
switch (b | M_0F
| (s->prefix & PREFIX_DATA ? P_66 : 0)
| (s->prefix & PREFIX_REPZ ? P_F3 : 0)
| (s->prefix & PREFIX_REPNZ ? P_F2 : 0)
| (REX_W(s) > 0 ? W_1 : W_0)) {
+#define CASES_LEG_NP_0F_W0(opcode) \
+ case opcode | M_0F | W_0:
+#define CASES_LEG_NP_0F_W1(opcode) \
+ case opcode | M_0F | W_1:
+#define CASES_LEG_F3_0F_W0(opcode) \
+ case opcode | M_0F | P_F3 | W_0:
+#define CASES_LEG_F3_0F_W1(opcode) \
+ case opcode | M_0F | P_F3 | W_1:
+
+#define LEG(p, m, w) \
+ CASES_LEG_ ## p ## _ ## m ## _W ## w
+#define INSN(mnem, cases, opcode, feat) \
+ cases(opcode) \
+ translate_insn( \
+ env, s, CK_CPUID_ ## feat, \
+ gen_insn(mnem)); \
+ return;
+#define INSN_R(mnem, cases, opcode, feat, opR1) \
+ cases(opcode) \
+ modrm = x86_ldub_code(env, s); \
+ translate_insn_r(opR1)( \
+ env, s, modrm, CK_CPUID_ ## feat, \
+ gen_insn_r(mnem, opR1)); \
+ return;
+#define INSN_RR(mnem, cases, opcode, feat, opR1, opR2) \
+ cases(opcode) \
+ modrm = x86_ldub_code(env, s); \
+ translate_insn_rr(opR1, opR2)( \
+ env, s, modrm, CK_CPUID_ ## feat, \
+ gen_insn_rr(mnem, opR1, opR2)); \
+ return;
+#define INSN_W(mnem, cases, opcode, feat, opW1) \
+ cases(opcode) \
+ modrm = x86_ldub_code(env, s); \
+ translate_insn_wr(opW1)( \
+ env, s, modrm, CK_CPUID_ ## feat, \
+ gen_insn_wr(mnem, opW1)); \
+ return;
+#define INSN_WR(mnem, cases, opcode, feat, opW1, opR1) \
+ cases(opcode) \
+ modrm = x86_ldub_code(env, s); \
+ translate_insn_wr(opW1, opR1)( \
+ env, s, modrm, CK_CPUID_ ## feat, \
+ gen_insn_wr(mnem, opW1, opR1)); \
+ return;
+#define INSN_WRR(mnem, cases, opcode, feat, opW1, opR1, opR2) \
+ cases(opcode) \
+ modrm = x86_ldub_code(env, s); \
+ translate_insn_wrr(opW1, opR1, opR2)( \
+ env, s, modrm, CK_CPUID_ ## feat, \
+ gen_insn_wrr(mnem, opW1, opR1, opR2)); \
+ return;
+#define INSN_WRRR(mnem, cases, opcode, feat, opW1, opR1, opR2, opR3) \
+ cases(opcode) \
+ modrm = x86_ldub_code(env, s); \
+ translate_insn_wrrr(opW1, opR1, opR2, opR3)( \
+ env, s, modrm, CK_CPUID_ ## feat, \
+ gen_insn_wrrr(mnem, opW1, opR1, opR2, opR3)); \
+ return;
+#define INSN_GRP(grpname, cases, opcode) \
+ cases(opcode) \
+ modrm = x86_ldub_code(env, s); \
+ translate_group(grpname)(env, s, modrm); \
+ return;
+#include "insn.h"
default:
gen_sse(env, s, b);
return;
+
+#undef CASES_LEG_NP_0F_W0
+#undef CASES_LEG_NP_0F_W1
+#undef CASES_LEG_F3_0F_W0
+#undef CASES_LEG_F3_0F_W1
}
g_assert_not_reached();
--
2.20.1
next prev parent reply other threads:[~2019-08-10 4:27 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-10 4:12 [Qemu-devel] [RFC PATCH v2 00/39] rewrite MMX/SSE instruction translation Jan Bobek
2019-08-10 4:12 ` [Qemu-devel] [RFC PATCH v2 01/39] target/i386: Push rex_r into DisasContext Jan Bobek
2019-08-10 4:12 ` [Qemu-devel] [RFC PATCH v2 02/39] target/i386: Push rex_w " Jan Bobek
2019-08-10 4:12 ` [Qemu-devel] [RFC PATCH v2 03/39] target/i386: reduce scope of variable aflag Jan Bobek
2019-08-13 4:47 ` Richard Henderson
2019-08-10 4:12 ` [Qemu-devel] [RFC PATCH v2 04/39] target/i386: use dflag from DisasContext Jan Bobek
2019-08-13 4:48 ` Richard Henderson
2019-08-10 4:12 ` [Qemu-devel] [RFC PATCH v2 05/39] target/i386: use prefix " Jan Bobek
2019-08-13 4:48 ` Richard Henderson
2019-08-10 4:12 ` [Qemu-devel] [RFC PATCH v2 06/39] target/i386: Simplify gen_exception arguments Jan Bobek
2019-08-10 4:12 ` [Qemu-devel] [RFC PATCH v2 07/39] target/i386: use pc_start from DisasContext Jan Bobek
2019-08-13 4:47 ` Richard Henderson
2019-08-10 4:12 ` [Qemu-devel] [RFC PATCH v2 08/39] target/i386: make variable b1 const Jan Bobek
2019-08-13 4:49 ` Richard Henderson
2019-08-10 4:12 ` [Qemu-devel] [RFC PATCH v2 09/39] target/i386: make variable is_xmm const Jan Bobek
2019-08-13 4:52 ` Richard Henderson
2019-08-10 4:12 ` [Qemu-devel] [RFC PATCH v2 10/39] target/i386: add vector register file alignment constraints Jan Bobek
2019-08-10 4:12 ` [Qemu-devel] [RFC PATCH v2 11/39] target/i386: introduce gen_(ld, st)d_env_A0 Jan Bobek
2019-08-13 4:56 ` Richard Henderson
2019-08-10 4:12 ` [Qemu-devel] [RFC PATCH v2 12/39] target/i386: introduce gen_sse_ng Jan Bobek
2019-08-13 5:00 ` Richard Henderson
2019-08-10 4:12 ` [Qemu-devel] [RFC PATCH v2 13/39] target/i386: disable unused function warning temporarily Jan Bobek
2019-08-10 4:12 ` [Qemu-devel] [RFC PATCH v2 14/39] target/i386: introduce mnemonic aliases for several gvec operations Jan Bobek
2019-08-13 5:01 ` Richard Henderson
2019-08-10 4:12 ` [Qemu-devel] [RFC PATCH v2 15/39] target/i386: introduce function ck_cpuid Jan Bobek
2019-08-13 5:07 ` Richard Henderson
2019-08-10 4:12 ` [Qemu-devel] [RFC PATCH v2 16/39] target/i386: introduce instruction operand infrastructure Jan Bobek
2019-08-13 6:07 ` Richard Henderson
2019-08-15 0:00 ` Jan Bobek
2019-08-15 9:09 ` Richard Henderson
2019-08-10 4:12 ` [Qemu-devel] [RFC PATCH v2 17/39] target/i386: introduce helpers for decoding modrm fields Jan Bobek
2019-08-10 4:12 ` [Qemu-devel] [RFC PATCH v2 18/39] target/i386: introduce modifier for direct-only operand decoding Jan Bobek
2019-08-10 4:12 ` [Qemu-devel] [RFC PATCH v2 19/39] target/i386: introduce generic operand alias Jan Bobek
2019-08-10 4:12 ` [Qemu-devel] [RFC PATCH v2 20/39] target/i386: introduce generic load-store operand Jan Bobek
2019-08-10 4:12 ` [Qemu-devel] [RFC PATCH v2 21/39] target/i386: introduce insn.h Jan Bobek
2019-08-13 6:00 ` Richard Henderson
2019-08-15 0:55 ` Jan Bobek
2019-08-10 4:12 ` [Qemu-devel] [RFC PATCH v2 22/39] target/i386: introduce code generators Jan Bobek
2019-08-10 4:12 ` Jan Bobek [this message]
2019-08-13 6:30 ` [Qemu-devel] [RFC PATCH v2 23/39] target/i386: introduce instruction translator macros Richard Henderson
2019-08-15 0:51 ` Jan Bobek
2019-08-10 4:12 ` [Qemu-devel] [RFC PATCH v2 24/39] target/i386: introduce Ib (immediate) operand Jan Bobek
2019-08-10 4:12 ` [Qemu-devel] [RFC PATCH v2 25/39] target/i386: introduce M* (memptr) operands Jan Bobek
2019-08-10 4:12 ` [Qemu-devel] [RFC PATCH v2 26/39] target/i386: introduce G*, R*, E* (general register) operands Jan Bobek
2019-08-10 4:12 ` [Qemu-devel] [RFC PATCH v2 27/39] target/i386: introduce RdMw operand Jan Bobek
2019-08-10 4:12 ` [Qemu-devel] [RFC PATCH v2 28/39] target/i386: introduce P*, N*, Q* (MMX) operands Jan Bobek
2019-08-10 4:12 ` [Qemu-devel] [RFC PATCH v2 29/39] target/i386: introduce helper-based code generator macros Jan Bobek
2019-08-10 4:12 ` [Qemu-devel] [RFC PATCH v2 30/39] target/i386: introduce gvec-based " Jan Bobek
2019-08-10 4:12 ` [Qemu-devel] [RFC PATCH v2 31/39] target/i386: introduce MMX translators Jan Bobek
2019-08-10 4:12 ` [Qemu-devel] [RFC PATCH v2 32/39] target/i386: introduce MMX code generators Jan Bobek
2019-08-10 4:12 ` [Qemu-devel] [RFC PATCH v2 33/39] target/i386: introduce MMX instructions to insn.h Jan Bobek
2019-08-10 4:12 ` [Qemu-devel] [RFC PATCH v2 34/39] target/i386: introduce V*, U*, W* (SSE/AVX) operands Jan Bobek
2019-08-10 4:12 ` [Qemu-devel] [RFC PATCH v2 35/39] target/i386: introduce UdqMq operand Jan Bobek
2019-08-10 4:12 ` [Qemu-devel] [RFC PATCH v2 36/39] target/i386: introduce SSE translators Jan Bobek
2019-08-10 4:12 ` [Qemu-devel] [RFC PATCH v2 37/39] target/i386: introduce SSE code generators Jan Bobek
2019-08-10 4:12 ` [Qemu-devel] [RFC PATCH v2 38/39] target/i386: introduce SSE instructions to insn.h Jan Bobek
2019-08-10 4:12 ` [Qemu-devel] [RFC PATCH v2 39/39] target/i386: introduce memory-pointer operand read/write workarounds Jan Bobek
2019-08-10 4:44 ` [Qemu-devel] [RFC PATCH v2 00/39] rewrite MMX/SSE instruction translation no-reply
2019-08-10 23:35 ` Richard Henderson
2019-08-11 15:49 ` Jan Bobek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190810041255.6820-24-jan.bobek@gmail.com \
--to=jan.bobek@gmail.com \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).