From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1268CC32753 for ; Wed, 14 Aug 2019 09:59:10 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D2A7E2083B for ; Wed, 14 Aug 2019 09:59:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D2A7E2083B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58802 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hxq3g-0003i7-Ru for qemu-devel@archiver.kernel.org; Wed, 14 Aug 2019 05:59:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53069) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hxq2y-00038p-Iy for qemu-devel@nongnu.org; Wed, 14 Aug 2019 05:58:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hxq2x-00022i-4f for qemu-devel@nongnu.org; Wed, 14 Aug 2019 05:58:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37308) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hxq2w-00022M-Vj for qemu-devel@nongnu.org; Wed, 14 Aug 2019 05:58:23 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DD83983F3C for ; Wed, 14 Aug 2019 09:58:21 +0000 (UTC) Received: from work-vm (ovpn-117-212.ams2.redhat.com [10.36.117.212]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C035E18243; Wed, 14 Aug 2019 09:58:16 +0000 (UTC) Date: Wed, 14 Aug 2019 10:58:13 +0100 From: "Dr. David Alan Gilbert" To: Stefan Hajnoczi Message-ID: <20190814095813.GA2921@work-vm> References: <20190813133042.11683-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190813133042.11683-1-stefanha@redhat.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Wed, 14 Aug 2019 09:58:21 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH] usb: reword -usb command-line option and mention xHCI X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, kraxel@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Stefan Hajnoczi (stefanha@redhat.com) wrote: > The -usb section of the man page is not very clear on what exactly -usb > does and fails to mention xHCI as a modern alternative (-device > nec-usb-xhci). Isn't 'qemu-xhci' the current favoured device? Dave > Signed-off-by: Stefan Hajnoczi > --- > qemu-options.hx | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/qemu-options.hx b/qemu-options.hx > index 9621e934c0..7d11c016d1 100644 > --- a/qemu-options.hx > +++ b/qemu-options.hx > @@ -1436,12 +1436,15 @@ STEXI > ETEXI > > DEF("usb", 0, QEMU_OPTION_usb, > - "-usb enable the USB driver (if it is not used by default yet)\n", > + "-usb enable on-board USB host controller (if not enabled by default)\n", > QEMU_ARCH_ALL) > STEXI > @item -usb > @findex -usb > -Enable the USB driver (if it is not used by default yet). > +Enable USB emulation on machine types with an on-board USB host controller (if > +not enabled by default). Note that on-board USB host controllers may not > +support USB 3.0. In this case -device nec-usb-xhci can be used instead on > +machines with PCI. > ETEXI > > DEF("usbdevice", HAS_ARG, QEMU_OPTION_usbdevice, > -- > 2.21.0 > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK