From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org
Cc: quintela@redhat.com, yury-kotov@yandex-team.ru,
richardw.yang@linux.intel.com, marcandre.lureau@redhat.com,
ivanren@tencent.com
Subject: [Qemu-devel] [PULL 22/33] hmp: Remove migration capabilities from "info migrate"
Date: Thu, 15 Aug 2019 17:34:53 +0100 [thread overview]
Message-ID: <20190815163504.18937-23-dgilbert@redhat.com> (raw)
In-Reply-To: <20190815163504.18937-1-dgilbert@redhat.com>
From: Wei Yang <richardw.yang@linux.intel.com>
With the growth of migration capabilities, it is not proper to display
them in "info migrate". Users are recommended to use "info
migrate_capabiltiies" to list them.
Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Suggested-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Message-Id: <20190806003645.8426-1-richardw.yang@linux.intel.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
monitor/hmp-cmds.c | 14 --------------
1 file changed, 14 deletions(-)
diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
index 5ca3ebe942..35788c0645 100644
--- a/monitor/hmp-cmds.c
+++ b/monitor/hmp-cmds.c
@@ -220,24 +220,11 @@ static char *SocketAddress_to_str(SocketAddress *addr)
void hmp_info_migrate(Monitor *mon, const QDict *qdict)
{
MigrationInfo *info;
- MigrationCapabilityStatusList *caps, *cap;
info = qmp_query_migrate(NULL);
- caps = qmp_query_migrate_capabilities(NULL);
migration_global_dump(mon);
- /* do not display parameters during setup */
- if (info->has_status && caps) {
- monitor_printf(mon, "capabilities: ");
- for (cap = caps; cap; cap = cap->next) {
- monitor_printf(mon, "%s: %s ",
- MigrationCapability_str(cap->value->capability),
- cap->value->state ? "on" : "off");
- }
- monitor_printf(mon, "\n");
- }
-
if (info->has_status) {
monitor_printf(mon, "Migration status: %s",
MigrationStatus_str(info->status));
@@ -370,7 +357,6 @@ void hmp_info_migrate(Monitor *mon, const QDict *qdict)
monitor_printf(mon, "]\n");
}
qapi_free_MigrationInfo(info);
- qapi_free_MigrationCapabilityStatusList(caps);
}
void hmp_info_migrate_capabilities(Monitor *mon, const QDict *qdict)
--
2.21.0
next prev parent reply other threads:[~2019-08-15 16:50 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 16:34 [Qemu-devel] [PULL 00/33] migration queue Dr. David Alan Gilbert (git)
2019-08-15 16:34 ` [Qemu-devel] [PULL 01/33] migration: Add error_desc for file channel errors Dr. David Alan Gilbert (git)
2019-08-15 16:34 ` [Qemu-devel] [PULL 02/33] hw/net: fix vmxnet3 live migration Dr. David Alan Gilbert (git)
2019-08-15 16:34 ` [Qemu-devel] [PULL 03/33] migration: consolidate time info into populate_time_info Dr. David Alan Gilbert (git)
2019-08-15 16:34 ` [Qemu-devel] [PULL 04/33] migration/postcopy: the valid condition is one less then end Dr. David Alan Gilbert (git)
2019-08-15 16:34 ` [Qemu-devel] [PULL 05/33] migration/postcopy: break the loop when there is no more page to discard Dr. David Alan Gilbert (git)
2019-08-15 16:34 ` [Qemu-devel] [PULL 06/33] migration/postcopy: discard_length must not be 0 Dr. David Alan Gilbert (git)
2019-08-15 16:34 ` [Qemu-devel] [PULL 07/33] migration/postcopy: reduce one operation to calculate fixup_start_addr Dr. David Alan Gilbert (git)
2019-08-15 16:34 ` [Qemu-devel] [PULL 08/33] migration/postcopy: do_fixup is true when host_offset is non-zero Dr. David Alan Gilbert (git)
2019-08-15 16:34 ` [Qemu-devel] [PULL 09/33] migration/savevm: flush file for iterable_only case Dr. David Alan Gilbert (git)
2019-08-15 16:34 ` [Qemu-devel] [PULL 10/33] migration/savevm: split qemu_savevm_state_complete_precopy() into two parts Dr. David Alan Gilbert (git)
2019-08-15 16:34 ` [Qemu-devel] [PULL 11/33] migration/savevm: move non SaveStateEntry condition check out of iteration Dr. David Alan Gilbert (git)
2019-08-15 16:34 ` [Qemu-devel] [PULL 12/33] migration/postcopy: PostcopyState is already set in loadvm_postcopy_handle_advise() Dr. David Alan Gilbert (git)
2019-08-15 16:34 ` [Qemu-devel] [PULL 13/33] migration/postcopy: start_postcopy could be true only when migrate_postcopy() return true Dr. David Alan Gilbert (git)
2019-08-15 16:34 ` [Qemu-devel] [PULL 14/33] migration: use migration_in_postcopy() to check POSTCOPY_ACTIVE Dr. David Alan Gilbert (git)
2019-08-15 16:34 ` [Qemu-devel] [PULL 15/33] migration: just pass RAMBlock is enough Dr. David Alan Gilbert (git)
2019-08-15 16:34 ` [Qemu-devel] [PULL 16/33] migration: equation is more proper than and to check LOADVM_QUIT Dr. David Alan Gilbert (git)
2019-08-15 16:34 ` [Qemu-devel] [PULL 17/33] migration: return -EINVAL directly when version_id mismatch Dr. David Alan Gilbert (git)
2019-08-15 16:34 ` [Qemu-devel] [PULL 18/33] migration: extract ram_load_precopy Dr. David Alan Gilbert (git)
2019-08-15 16:34 ` [Qemu-devel] [PULL 19/33] migration/postcopy: make PostcopyDiscardState a static variable Dr. David Alan Gilbert (git)
2019-08-15 16:34 ` [Qemu-devel] [PULL 20/33] migration/postcopy: simplify calculation of run_start and fixup_start_addr Dr. David Alan Gilbert (git)
2019-08-15 16:34 ` [Qemu-devel] [PULL 21/33] migration/postcopy: use QEMU_IS_ALIGNED to replace host_offset Dr. David Alan Gilbert (git)
2019-08-15 16:34 ` Dr. David Alan Gilbert (git) [this message]
2019-08-15 16:34 ` [Qemu-devel] [PULL 23/33] migration: remove unused field bytes_xfer Dr. David Alan Gilbert (git)
2019-08-15 16:34 ` [Qemu-devel] [PULL 24/33] migration: always initialise ram_counters for a new migration Dr. David Alan Gilbert (git)
2019-08-15 16:34 ` [Qemu-devel] [PULL 25/33] migration: add qemu_file_update_transfer interface Dr. David Alan Gilbert (git)
2019-08-15 16:34 ` [Qemu-devel] [PULL 26/33] migration: add speed limit for multifd migration Dr. David Alan Gilbert (git)
2019-08-15 16:34 ` [Qemu-devel] [PULL 27/33] migration: update ram_counters for multifd sync packet Dr. David Alan Gilbert (git)
2019-08-15 16:34 ` [Qemu-devel] [PULL 28/33] migration: rename migration_bitmap_sync_range to ramblock_sync_dirty_bitmap Dr. David Alan Gilbert (git)
2019-08-15 16:35 ` [Qemu-devel] [PULL 29/33] migration/postcopy: use mis->bh instead of allocating a QEMUBH Dr. David Alan Gilbert (git)
2019-08-15 16:35 ` [Qemu-devel] [PULL 30/33] qemu-file: move qemu_{get, put}_counted_string() declarations Dr. David Alan Gilbert (git)
2019-08-15 16:35 ` [Qemu-devel] [PULL 31/33] migration: Add traces for multifd terminate threads Dr. David Alan Gilbert (git)
2019-08-15 16:35 ` [Qemu-devel] [PULL 32/33] migration: Make global sem_sync semaphore by channel Dr. David Alan Gilbert (git)
2019-08-15 16:35 ` [Qemu-devel] [PULL 33/33] migration: add some multifd traces Dr. David Alan Gilbert (git)
2019-08-16 12:58 ` [Qemu-devel] [PULL 00/33] migration queue Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190815163504.18937-23-dgilbert@redhat.com \
--to=dgilbert@redhat.com \
--cc=ivanren@tencent.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=richardw.yang@linux.intel.com \
--cc=yury-kotov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).