From: Erik Skultety <eskultet@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Peter Krempa <pkrempa@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Like Xu <like.xu@linux.intel.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org, Igor Mammedov <imammedo@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH 3/3] pc: Don't make CPU properties mandatory unless necessary
Date: Fri, 16 Aug 2019 09:49:32 +0200 [thread overview]
Message-ID: <20190816074932.GK13569@beluga.usersys.redhat.com> (raw)
In-Reply-To: <87pnl5sks3.fsf@dusky.pond.sub.org>
On Fri, Aug 16, 2019 at 08:10:20AM +0200, Markus Armbruster wrote:
> Eduardo Habkost <ehabkost@redhat.com> writes:
>
> > We have this issue reported when using libvirt to hotplug CPUs:
> > https://bugzilla.redhat.com/show_bug.cgi?id=1741451
> >
> > Basically, libvirt is not copying die-id from
> > query-hotpluggable-cpus, but die-id is now mandatory.
>
> Uh-oh, "is now mandatory": making an optional property mandatory is an
> incompatible change. When did we do that? Commit hash, please.
>
> [...]
>
I don't even see it as being optional ever - the property wasn't even
recognized before commit 176d2cda0de introduced it as mandatory.
Regards,
Erik
next prev parent reply other threads:[~2019-08-16 8:11 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 18:38 [Qemu-devel] [PATCH 0/3] pc: Fix die-id validation and compatibility with libvirt Eduardo Habkost
2019-08-15 18:38 ` [Qemu-devel] [PATCH 1/3] pc: Fix error message on die-id validation Eduardo Habkost
2019-08-15 20:04 ` Vanderson Martins do Rosario
2019-08-16 1:04 ` Like Xu
2019-08-16 13:49 ` Eduardo Habkost
2019-08-19 0:53 ` Like Xu
2019-08-16 6:06 ` Markus Armbruster
2019-08-16 14:04 ` Igor Mammedov
2019-08-15 18:38 ` [Qemu-devel] [PATCH 2/3] pc: Improve error message when die-id is omitted Eduardo Habkost
2019-08-15 20:11 ` Vanderson Martins do Rosario
2019-08-16 14:06 ` Igor Mammedov
2019-08-15 18:38 ` [Qemu-devel] [PATCH 3/3] pc: Don't make CPU properties mandatory unless necessary Eduardo Habkost
2019-08-16 6:10 ` Markus Armbruster
2019-08-16 7:49 ` Erik Skultety [this message]
2019-08-16 12:22 ` Markus Armbruster
2019-08-16 17:42 ` Eduardo Habkost
2019-08-16 21:07 ` Yash Mankad
2019-08-20 21:06 ` Eduardo Habkost
2019-08-17 5:34 ` Markus Armbruster
2019-08-16 16:49 ` Eduardo Habkost
2019-08-16 13:20 ` Igor Mammedov
2019-08-16 16:56 ` Eduardo Habkost
2019-08-17 6:17 ` Markus Armbruster
2019-08-26 14:51 ` Igor Mammedov
2019-08-27 16:15 ` Markus Armbruster
2019-08-28 15:27 ` Igor Mammedov
2019-08-19 19:19 ` [Qemu-devel] [PATCH 0/3] pc: Fix die-id validation and compatibility with libvirt Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190816074932.GK13569@beluga.usersys.redhat.com \
--to=eskultet@redhat.com \
--cc=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=like.xu@linux.intel.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pkrempa@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).