From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EA2AC3A589 for ; Sun, 18 Aug 2019 13:06:31 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0A8AB2054F for ; Sun, 18 Aug 2019 13:06:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0A8AB2054F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=haasn.xyz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41124 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzKtC-0004Ha-5H for qemu-devel@archiver.kernel.org; Sun, 18 Aug 2019 09:06:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35529) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzInJ-0001Lt-2K for qemu-devel@nongnu.org; Sun, 18 Aug 2019 06:52:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hzImA-0007D4-CJ for qemu-devel@nongnu.org; Sun, 18 Aug 2019 06:51:07 -0400 Received: from haasn.xyz ([78.46.187.166]:43508) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hzImA-0007A3-48 for qemu-devel@nongnu.org; Sun, 18 Aug 2019 06:51:06 -0400 Received: from haasn.xyz (unknown [10.30.0.2]) by haasn.xyz (Postfix) with ESMTP id C38AA401EE; Sun, 18 Aug 2019 12:50:59 +0200 (CEST) From: Niklas Haas To: qemu-devel@nongnu.org Date: Sun, 18 Aug 2019 12:50:38 +0200 Message-Id: <20190818105038.19520-1-qemu@haasn.xyz> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 78.46.187.166 X-Mailman-Approved-At: Sun, 18 Aug 2019 09:05:30 -0400 Subject: [Qemu-devel] [PATCH] input-linux: add shift+shift as a grab toggle X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Niklas Haas Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Niklas Haas We have ctrl-ctrl and alt-alt; why not shift-shift? That's my preferred grab binding, personally. Signed-off-by: Niklas Haas --- qapi/ui.json | 3 ++- ui/input-linux.c | 4 ++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/qapi/ui.json b/qapi/ui.json index 59e412139a..e04525d8b4 100644 --- a/qapi/ui.json +++ b/qapi/ui.json @@ -1025,7 +1025,8 @@ # ## { 'enum': 'GrabToggleKeys', - 'data': [ 'ctrl-ctrl', 'alt-alt', 'meta-meta', 'scrolllock', 'ctrl-scr= olllock' ] } + 'data': [ 'ctrl-ctrl', 'alt-alt', 'shift-shift','meta-meta', 'scrolllo= ck', + 'ctrl-scrolllock' ] } =20 ## # @DisplayGTK: diff --git a/ui/input-linux.c b/ui/input-linux.c index 59456fe765..a7b280b25b 100644 --- a/ui/input-linux.c +++ b/ui/input-linux.c @@ -113,6 +113,10 @@ static bool input_linux_check_toggle(InputLinux *il) return il->keydown[KEY_LEFTALT] && il->keydown[KEY_RIGHTALT]; =20 + case GRAB_TOGGLE_KEYS_SHIFT_SHIFT: + return il->keydown[KEY_LEFTSHIFT] && + il->keydown[KEY_RIGHTSHIFT]; + case GRAB_TOGGLE_KEYS_META_META: return il->keydown[KEY_LEFTMETA] && il->keydown[KEY_RIGHTMETA]; --=20 2.21.0