From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=FROM_EXCESS_BASE64, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C96F3C3A589 for ; Tue, 20 Aug 2019 08:40:03 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8EE112341B for ; Tue, 20 Aug 2019 08:40:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8EE112341B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34756 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzzgQ-0001b5-O9 for qemu-devel@archiver.kernel.org; Tue, 20 Aug 2019 04:40:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56470) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzzfp-00017L-EI for qemu-devel@nongnu.org; Tue, 20 Aug 2019 04:39:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hzzfn-00088z-Mn for qemu-devel@nongnu.org; Tue, 20 Aug 2019 04:39:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33552) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hzzfk-00083D-E5; Tue, 20 Aug 2019 04:39:20 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7919F300BEA4; Tue, 20 Aug 2019 08:39:19 +0000 (UTC) Received: from redhat.com (ovpn-112-61.ams2.redhat.com [10.36.112.61]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 916AA1F5; Tue, 20 Aug 2019 08:39:07 +0000 (UTC) Date: Tue, 20 Aug 2019 09:39:04 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Juan Quintela Message-ID: <20190820083904.GA23352@redhat.com> References: <20190820082459.2101-1-quintela@redhat.com> <20190820082459.2101-2-quintela@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190820082459.2101-2-quintela@redhat.com> User-Agent: Mutt/1.12.0 (2019-05-25) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Tue, 20 Aug 2019 08:39:19 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH v2 1/5] socket: Add backlog parameter to socket_listen X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Fam Zheng , Kevin Wolf , Michael Roth , qemu-block@nongnu.org, qemu-devel@nongnu.org, Max Reitz , Gerd Hoffmann , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Paolo Bonzini , "Dr. David Alan Gilbert" , Stefan Berger Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Aug 20, 2019 at 10:24:55AM +0200, Juan Quintela wrote: > Current parameter was always one. We continue with that value for now > in all callers. > > Signed-off-by: Juan Quintela > --- > include/qemu/sockets.h | 2 +- > io/channel-socket.c | 2 +- > qga/channel-posix.c | 2 +- > tests/test-util-sockets.c | 12 ++++++------ > util/qemu-sockets.c | 33 ++++++++++++++++++++++----------- > util/trace-events | 2 ++ > 6 files changed, 33 insertions(+), 20 deletions(-) > > diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c > index e3a1666578..3f0a80404f 100644 > --- a/util/qemu-sockets.c > +++ b/util/qemu-sockets.c > @@ -31,6 +31,7 @@ > #include "qapi/qobject-input-visitor.h" > #include "qapi/qobject-output-visitor.h" > #include "qemu/cutils.h" > +#include "trace.h" > > #ifndef AI_ADDRCONFIG > # define AI_ADDRCONFIG 0 > @@ -207,6 +208,7 @@ static int try_bind(int socket, InetSocketAddress *saddr, struct addrinfo *e) > > static int inet_listen_saddr(InetSocketAddress *saddr, > int port_offset, > + int num, > Error **errp) > { > struct addrinfo ai,*res,*e; > @@ -309,7 +311,8 @@ static int inet_listen_saddr(InetSocketAddress *saddr, > goto listen_failed; > } > } else { > - if (!listen(slisten, 1)) { > + trace_inet_listen_saddr(num); It is a bit odd to only have the trace event for inet sockets. I'd prefer it in the caller for all sockets, with just "socket_listen" name. > + if (!listen(slisten, num)) { > goto listen_ok; > } > if (errno != EADDRINUSE) { Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|