From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Eduardo Habkost <ehabkost@redhat.com>,
Corey Minyard <minyard@acm.org>,
Juan Quintela <quintela@redhat.com>,
qemu-trivial@nongnu.org, Jason Wang <jasowang@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Michael Tokarev <mjt@tls.msk.ru>,
Markus Armbruster <armbru@redhat.com>,
Laurent Vivier <laurent@vivier.eu>,
"tony.nguyen@bt.com" <tony.nguyen@bt.com>,
qemu-ppc@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: [Qemu-devel] [PULL 01/14] test: Use g_strndup instead of plain strndup
Date: Wed, 21 Aug 2019 13:19:34 +0200 [thread overview]
Message-ID: <20190821111947.26580-2-laurent@vivier.eu> (raw)
In-Reply-To: <20190821111947.26580-1-laurent@vivier.eu>
From: "tony.nguyen@bt.com" <tony.nguyen@bt.com>
Due to memory management rules. See HACKING.
Signed-off-by: Tony Nguyen <tony.nguyen@bt.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <dce313b46d294ada8826d34609a3447e@tpw09926dag18e.domain1.systemhost.net>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
tests/check-qjson.c | 2 +-
tests/migration/stress.c | 8 ++++----
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/tests/check-qjson.c b/tests/check-qjson.c
index fa2afccb0a24..07a773e6530b 100644
--- a/tests/check-qjson.c
+++ b/tests/check-qjson.c
@@ -767,7 +767,7 @@ static void utf8_string(void)
if (*end == ' ') {
end++;
}
- in = strndup(tail, end - tail);
+ in = g_strndup(tail, end - tail);
str = from_json_str(in, j, NULL);
g_assert(!str);
g_free(in);
diff --git a/tests/migration/stress.c b/tests/migration/stress.c
index 49a03aab7b83..d9aa4afe928b 100644
--- a/tests/migration/stress.c
+++ b/tests/migration/stress.c
@@ -104,9 +104,9 @@ static int get_command_arg_str(const char *name,
}
if (end)
- *val = strndup(start, end - start);
+ *val = g_strndup(start, end - start);
else
- *val = strdup(start);
+ *val = g_strdup(start);
return 1;
}
@@ -126,10 +126,10 @@ static int get_command_arg_ull(const char *name,
if (errno || *end) {
fprintf(stderr, "%s (%05d): ERROR: cannot parse %s value %s\n",
argv0, gettid(), name, valstr);
- free(valstr);
+ g_free(valstr);
return -1;
}
- free(valstr);
+ g_free(valstr);
return 0;
}
--
2.21.0
next prev parent reply other threads:[~2019-08-21 11:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 11:19 [Qemu-devel] [PULL 00/14] Trivial branch patches Laurent Vivier
2019-08-21 11:19 ` Laurent Vivier [this message]
2019-08-21 11:19 ` [Qemu-devel] [PULL 02/14] misc: fix naming scheme of compatiblity arrays Laurent Vivier
2019-08-21 11:19 ` [Qemu-devel] [PULL 03/14] configure: remove obsoleted $sparc_cpu variable Laurent Vivier
2019-08-21 11:19 ` [Qemu-devel] [PULL 04/14] configure: fix sdl detection using sdl2-config Laurent Vivier
2019-08-21 11:19 ` [Qemu-devel] [PULL 05/14] .gitignore: ignore some vhost-user* related files Laurent Vivier
2019-08-21 11:19 ` [Qemu-devel] [PULL 06/14] hw/net/e1000: Fix erroneous comment Laurent Vivier
2019-08-21 11:19 ` [Qemu-devel] [PULL 07/14] json: Move switch 'fall through' comment to correct place Laurent Vivier
2019-08-21 11:19 ` [Qemu-devel] [PULL 08/14] hw/dma/omap_dma: " Laurent Vivier
2019-08-21 11:19 ` [Qemu-devel] [PULL 09/14] hw/ipmi: Rewrite a fall through comment Laurent Vivier
2019-08-21 11:48 ` Corey Minyard
2019-08-21 11:19 ` [Qemu-devel] [PULL 10/14] target/ppc: " Laurent Vivier
2019-08-21 11:19 ` [Qemu-devel] [PULL 11/14] vl: " Laurent Vivier
2019-08-21 11:19 ` [Qemu-devel] [PULL 12/14] spapr_events: " Laurent Vivier
2019-08-21 11:19 ` [Qemu-devel] [PULL 13/14] hw/display/sm501: Remove unused include Laurent Vivier
2019-08-21 11:19 ` [Qemu-devel] [PULL 14/14] hw/display: Compile various display devices as common object Laurent Vivier
2019-08-22 9:30 ` [Qemu-devel] [PULL 00/14] Trivial branch patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190821111947.26580-2-laurent@vivier.eu \
--to=laurent@vivier.eu \
--cc=armbru@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=jasowang@redhat.com \
--cc=minyard@acm.org \
--cc=mjt@tls.msk.ru \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=quintela@redhat.com \
--cc=rth@twiddle.net \
--cc=tony.nguyen@bt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).