From: Sandra Loosemore <sandra@codesourcery.com>
To: <qemu-devel@nongnu.org>
Cc: Marek Vasut <marex@denx.de>, Chris Wulff <crwulff@gmail.com>,
Laurent Vivier <laurent@vivier.eu>
Subject: [Qemu-devel] [PATCH V2 0/2] Fix bug in nios2 and m68k semihosting
Date: Wed, 21 Aug 2019 11:50:27 -0600 [thread overview]
Message-ID: <20190821175029.21868-1-sandra@codesourcery.com> (raw)
I noticed recently that the exit semihosting call on nios2 was
ignoring its parameter and always returning status 0 instead. It
turns out the handler was retrieving the value of the wrong register.
Since the nios2 semihosting implementation was basically
cut-and-pasted from that for m68k, I checked m68k also and it had the
same bug. This set of patches fixes both of them.
There are no changes to the actual patches from V1, only more
informative commit messages with links to the respective semihosting
protocol documents in newlib.
Sandra Loosemore (2):
target/nios2: Fix bug in semihosted exit handling
target/m68k: Fix bug in semihosted exit handling
target/m68k/m68k-semi.c | 4 ++--
target/nios2/nios2-semi.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
--
2.8.1
next reply other threads:[~2019-08-21 18:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 17:50 Sandra Loosemore [this message]
2019-08-21 17:50 ` [Qemu-devel] [PATCH V2 1/2] target/nios2: Fix bug in semihosted exit handling Sandra Loosemore
2019-08-21 17:50 ` [Qemu-devel] [PATCH V2 2/2] target/m68k: " Sandra Loosemore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190821175029.21868-1-sandra@codesourcery.com \
--to=sandra@codesourcery.com \
--cc=crwulff@gmail.com \
--cc=laurent@vivier.eu \
--cc=marex@denx.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).