qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, Wei Yang <richardw.yang@linux.intel.com>
Subject: Re: [Qemu-devel] [PATCH] tests: make filemonitor test more robust to event ordering
Date: Thu, 22 Aug 2019 11:37:44 +0800	[thread overview]
Message-ID: <20190822033744.GB7461@xz-x1> (raw)
In-Reply-To: <20190821155327.25208-1-berrange@redhat.com>

On Wed, Aug 21, 2019 at 04:53:27PM +0100, Daniel P. Berrangé wrote:
> The ordering of events that are emitted during the rmdir
> test have changed with kernel >= 5.3. Semantically both
> new & old orderings are correct, so we must be able to
> cope with either.
> 
> To cope with this, when we see an unexpected event, we
> push it back onto the queue and look and the subsequent
> event to see if that matches instead.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

Thanks for fixing it!

Tested-by: Peter Xu <peterx@redhat.com>

-- 
Peter Xu


  parent reply	other threads:[~2019-08-22  3:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-21 15:53 [Qemu-devel] [PATCH] tests: make filemonitor test more robust to event ordering Daniel P. Berrangé
2019-08-22  0:35 ` Wei Yang
2019-08-22  3:37 ` Peter Xu [this message]
2019-08-22 16:21 ` Cornelia Huck
2019-09-04 10:10 ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190822033744.GB7461@xz-x1 \
    --to=peterx@redhat.com \
    --cc=berrange@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richardw.yang@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).