* [Qemu-devel] [PATCH] hw/net/vmxnet3: Fix leftover unregister_savevm
@ 2019-08-22 11:12 Dr. David Alan Gilbert (git)
2019-08-27 9:01 ` Dmitry Fleytman
2019-09-12 10:14 ` Dr. David Alan Gilbert
0 siblings, 2 replies; 3+ messages in thread
From: Dr. David Alan Gilbert (git) @ 2019-08-22 11:12 UTC (permalink / raw)
To: qemu-devel, dmitry.fleytman, jasowang; +Cc: quintela
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Commit 78dd48df3 reworked vmxnet3's live migration but left a straggling
unregister_savevm call. Remove it, although it doesn't seem to have
any bad effect.
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
hw/net/vmxnet3.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c
index b07adeed9c..39ff6624c5 100644
--- a/hw/net/vmxnet3.c
+++ b/hw/net/vmxnet3.c
@@ -2242,13 +2242,10 @@ static void vmxnet3_instance_init(Object *obj)
static void vmxnet3_pci_uninit(PCIDevice *pci_dev)
{
- DeviceState *dev = DEVICE(pci_dev);
VMXNET3State *s = VMXNET3(pci_dev);
VMW_CBPRN("Starting uninit...");
- unregister_savevm(dev, "vmxnet3-msix", s);
-
vmxnet3_net_uninit(s);
vmxnet3_cleanup_msix(s);
--
2.21.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] hw/net/vmxnet3: Fix leftover unregister_savevm
2019-08-22 11:12 [Qemu-devel] [PATCH] hw/net/vmxnet3: Fix leftover unregister_savevm Dr. David Alan Gilbert (git)
@ 2019-08-27 9:01 ` Dmitry Fleytman
2019-09-12 10:14 ` Dr. David Alan Gilbert
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Fleytman @ 2019-08-27 9:01 UTC (permalink / raw)
To: Dr. David Alan Gilbert (git); +Cc: Jason Wang, qemu-devel, quintela
> On 22 Aug 2019, at 14:12, Dr. David Alan Gilbert (git) <dgilbert@redhat.com> wrote:
>
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> Commit 78dd48df3 reworked vmxnet3's live migration but left a straggling
> unregister_savevm call. Remove it, although it doesn't seem to have
> any bad effect.
>
Reviewed-by: Dmitry Fleytman <dmitry.fleytman@gmail.com>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> hw/net/vmxnet3.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c
> index b07adeed9c..39ff6624c5 100644
> --- a/hw/net/vmxnet3.c
> +++ b/hw/net/vmxnet3.c
> @@ -2242,13 +2242,10 @@ static void vmxnet3_instance_init(Object *obj)
>
> static void vmxnet3_pci_uninit(PCIDevice *pci_dev)
> {
> - DeviceState *dev = DEVICE(pci_dev);
> VMXNET3State *s = VMXNET3(pci_dev);
>
> VMW_CBPRN("Starting uninit...");
>
> - unregister_savevm(dev, "vmxnet3-msix", s);
> -
> vmxnet3_net_uninit(s);
>
> vmxnet3_cleanup_msix(s);
> --
> 2.21.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] hw/net/vmxnet3: Fix leftover unregister_savevm
2019-08-22 11:12 [Qemu-devel] [PATCH] hw/net/vmxnet3: Fix leftover unregister_savevm Dr. David Alan Gilbert (git)
2019-08-27 9:01 ` Dmitry Fleytman
@ 2019-09-12 10:14 ` Dr. David Alan Gilbert
1 sibling, 0 replies; 3+ messages in thread
From: Dr. David Alan Gilbert @ 2019-09-12 10:14 UTC (permalink / raw)
To: qemu-devel, dmitry.fleytman, jasowang; +Cc: quintela
* Dr. David Alan Gilbert (git) (dgilbert@redhat.com) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> Commit 78dd48df3 reworked vmxnet3's live migration but left a straggling
> unregister_savevm call. Remove it, although it doesn't seem to have
> any bad effect.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Queued
> ---
> hw/net/vmxnet3.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c
> index b07adeed9c..39ff6624c5 100644
> --- a/hw/net/vmxnet3.c
> +++ b/hw/net/vmxnet3.c
> @@ -2242,13 +2242,10 @@ static void vmxnet3_instance_init(Object *obj)
>
> static void vmxnet3_pci_uninit(PCIDevice *pci_dev)
> {
> - DeviceState *dev = DEVICE(pci_dev);
> VMXNET3State *s = VMXNET3(pci_dev);
>
> VMW_CBPRN("Starting uninit...");
>
> - unregister_savevm(dev, "vmxnet3-msix", s);
> -
> vmxnet3_net_uninit(s);
>
> vmxnet3_cleanup_msix(s);
> --
> 2.21.0
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-12 10:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-22 11:12 [Qemu-devel] [PATCH] hw/net/vmxnet3: Fix leftover unregister_savevm Dr. David Alan Gilbert (git)
2019-08-27 9:01 ` Dmitry Fleytman
2019-09-12 10:14 ` Dr. David Alan Gilbert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).