qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-s390x@nongnu.org, Cornelia Huck <cohuck@redhat.com>,
	qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH for-4.1?] compat: disable edid on virtio-gpu base device
Date: Thu, 22 Aug 2019 15:58:32 +0200	[thread overview]
Message-ID: <20190822135839.32340-2-cohuck@redhat.com> (raw)
In-Reply-To: <20190822135839.32340-1-cohuck@redhat.com>

'edid' is a property of the virtio-gpu base device, so turning
it off on virtio-gpu-pci is not enough (it misses -ccw). Turn
it off on the base device instead.

Fixes: 0a71966253c8 ("edid: flip the default to enabled")
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---

Only just noticed this... should we still shove this into 4.1?
Or do we need a compat 4.1.1 dance for this?

---
 hw/core/machine.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/core/machine.c b/hw/core/machine.c
index 28a475ad97a3..32d1ca9abc5a 100644
--- a/hw/core/machine.c
+++ b/hw/core/machine.c
@@ -32,7 +32,7 @@ GlobalProperty hw_compat_4_0[] = {
     { "secondary-vga",  "edid", "false" },
     { "bochs-display",  "edid", "false" },
     { "virtio-vga",     "edid", "false" },
-    { "virtio-gpu-pci", "edid", "false" },
+    { "virtio-gpu",     "edid", "false" },
     { "virtio-device", "use-started", "false" },
     { "virtio-balloon-device", "qemu-4-0-config-size", "true" },
     { "pl031", "migrate-tick-offset", "false" },
-- 
2.20.1



  reply	other threads:[~2019-08-22 14:00 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-22 13:58 [Qemu-devel] [PULL 0/7] First batch of s390x changes for 4.2 Cornelia Huck
2019-08-22 13:58 ` Cornelia Huck [this message]
2019-08-22 14:03   ` [Qemu-devel] [PATCH for-4.1?] compat: disable edid on virtio-gpu base device Cornelia Huck
2019-08-22 14:45   ` no-reply
2019-08-22 13:58 ` [Qemu-devel] [PULL 1/7] s390x/tcg: Fix VERIM with 32/64 bit elements Cornelia Huck
2019-08-22 13:58 ` [Qemu-devel] [PULL 2/7] s390x/mmu: Trace the right value if setting/getting the storage key fails Cornelia Huck
2019-08-22 13:58 ` [Qemu-devel] [PULL 3/7] s390x/mmu: ASC selection in s390_cpu_get_phys_page_debug() Cornelia Huck
2019-08-22 13:58 ` [Qemu-devel] [PULL 4/7] s390x/tcg: Rework MMU selection for instruction fetches Cornelia Huck
2019-08-22 13:58 ` [Qemu-devel] [PULL 5/7] s390x/tcg: Flush the TLB of all CPUs on SSKE and RRBE Cornelia Huck
2019-08-22 13:58 ` [Qemu-devel] [PULL 6/7] s390x/mmu: Better storage key reference and change bit handling Cornelia Huck
2019-08-22 13:58 ` [Qemu-devel] [PULL 7/7] s390x/mmu: Factor out storage key handling Cornelia Huck
2019-08-23 15:11 ` [Qemu-devel] [PULL 0/7] First batch of s390x changes for 4.2 Peter Maydell
  -- strict thread matches above, loose matches on Subject: below --
2019-08-06 11:58 [Qemu-devel] [PATCH for-4.1?] compat: disable edid on virtio-gpu base device Cornelia Huck
2019-08-06 13:39 ` Gerd Hoffmann
2019-08-06 13:42   ` Peter Maydell
2019-08-06 15:40     ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190822135839.32340-2-cohuck@redhat.com \
    --to=cohuck@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).