From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: slirp@lists.freedesktop.org
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
qemu-stable@nongnu.org, "Petr Matousek" <pmatouse@redhat.com>,
qemu-devel@nongnu.org, "Prasad J Pandit" <ppandit@redhat.com>
Subject: [Qemu-devel] [PATCH 0/2] slirp: Fix heap buffer overflow during packet reassembly (CVE-2019-14378)
Date: Thu, 22 Aug 2019 16:41:32 +0200 [thread overview]
Message-ID: <20190822144134.23521-1-philmd@redhat.com> (raw)
Hi, this is a SLiRP bug, however as QEMU comsumes the library, it is
directly concerned, so I'm cross-posting both QEMU and SLiRP lists
for a stricter review.
The 2nd patch is a PoC, to give QEMU a chance to shutdown properly
if SLiRP internals get corrupted. Simply sent as RFC.
The vulnerability is very well described here:
https://vishnudevtj.github.io/notes/qemu-vm-escape-cve-2019-14378
Exploit (used as reproducer):
https://github.com/vishnudevtj/exploits/blob/master/qemu/CVE-2019-14378/exp.c
Philippe Mathieu-Daudé (2):
Do not reassemble fragments pointing outside of the original payload
RFC Delay crash when mbufs are corrupted
src/ip_input.c | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
--
2.20.1
next reply other threads:[~2019-08-22 14:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 14:41 Philippe Mathieu-Daudé [this message]
2019-08-22 14:41 ` [Qemu-devel] [PATCH 1/2] Do not reassemble fragments pointing outside of the original payload Philippe Mathieu-Daudé
2019-08-22 18:33 ` [Qemu-devel] [Slirp] " Samuel Thibault
2019-08-23 15:15 ` Philippe Mathieu-Daudé
2019-08-25 22:54 ` Samuel Thibault
2019-08-29 11:13 ` P J P
2019-08-29 15:43 ` Philippe Mathieu-Daudé
2019-08-29 15:53 ` Philippe Mathieu-Daudé
2019-08-29 16:00 ` Philippe Mathieu-Daudé
2019-08-22 14:41 ` [Qemu-devel] [RFC PATCH 2/2] Delay crash when mbufs are corrupted Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190822144134.23521-1-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=pmatouse@redhat.com \
--cc=ppandit@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=slirp@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).