[Qemu-devel] 'make check-unit' breakage on s390x host

[Qemu-devel] 'make check-unit' breakage on s390x host

[Cornelia Huck]

I just noticed a breakage with 'make check-unit' when running on an
s390x host (on my laptop, it runs fine; haven't tried other
architectures). This happens with current master, but I managed to
track the original breakage down to

commit ff3dc8fefe953fd3650279e064bf63b212c5699a
Author: Daniel P. Berrangé <berrange@redhat.com>
Date:   Wed Mar 13 17:36:18 2019 +0000

    filemon: ensure watch IDs are unique to QFileMonitor scope
    
    The watch IDs are mistakenly only unique within the scope of the
    directory being monitored. This is not useful for clients which are
    monitoring multiple directories. They require watch IDs to be unique
    globally within the QFileMonitor scope.
    
    Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
    Tested-by: Bandan Das <bsd@redhat.com>
    Reviewed-by: Bandan Das <bsd@redhat.com>
    Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

On that commit, make check-unit fails with

  TEST    check-unit: tests/test-util-filemonitor
Expected watch id 4 but got 0
**
ERROR:/root/git/qemu/tests/test-util-filemonitor.c:651:test_file_monitor_events: assertion failed: (err == 0)
ERROR - Bail out! ERROR:/root/git/qemu/tests/test-util-filemonitor.c:651:test_file_monitor_events: assertion failed: (err == 0)
make: *** [/root/git/qemu/tests/Makefile.include:908: check-unit] Error 1

(I usually run as root on that box and as a normal user on my laptop;
not sure if that makes a difference.)

On master, the failure looks a bit different, but it's probably the
same issue:

  TEST    check-unit: tests/test-util-filemonitor
Expected watch id 200000000 but got 100000000
**
ERROR:/root/git/qemu/tests/test-util-filemonitor.c:665:test_file_monitor_events: assertion failed: (err == 0)
ERROR - Bail out! ERROR:/root/git/qemu/tests/test-util-filemonitor.c:665:test_file_monitor_events: assertion failed: (err == 0)
make: *** [/root/git/qemu/tests/Makefile.include:904: check-unit] Error 1

Fedora 29, QEMU built with '/root/git/qemu/build/../configure'
'--target-list=s390x-softmmu x86_64-softmmu' '--enable-kvm'
'--enable-linux-aio' '--enable-virtfs' '--enable-trace-backends=simple'
'--python=/usr/bin/python3'

I can try to collect extra info if you tell me what would be helpful.

Re: [Qemu-devel] 'make check-unit' breakage on s390x host

[Daniel P. Berrangé]

On Thu, Aug 22, 2019 at 05:44:47PM +0200, Cornelia Huck wrote:
> I just noticed a breakage with 'make check-unit' when running on an
> s390x host (on my laptop, it runs fine; haven't tried other
> architectures). This happens with current master, but I managed to
> track the original breakage down to
> 
> commit ff3dc8fefe953fd3650279e064bf63b212c5699a
> Author: Daniel P. Berrangé <berrange@redhat.com>
> Date:   Wed Mar 13 17:36:18 2019 +0000
> 
>     filemon: ensure watch IDs are unique to QFileMonitor scope

[snip]

> I can try to collect extra info if you tell me what would be helpful.

I'm betting you updated to kernel 5.3

  https://lists.gnu.org/archive/html/qemu-devel/2019-08/msg04349.html

Just waiting for a Reviewed-by on that patch in order to send a PR....

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [Qemu-devel] 'make check-unit' breakage on s390x host

[Cornelia Huck]

On Thu, 22 Aug 2019 16:55:13 +0100
Daniel P. Berrangé <berrange@redhat.com> wrote:

> On Thu, Aug 22, 2019 at 05:44:47PM +0200, Cornelia Huck wrote:
> > I just noticed a breakage with 'make check-unit' when running on an
> > s390x host (on my laptop, it runs fine; haven't tried other
> > architectures). This happens with current master, but I managed to
> > track the original breakage down to
> > 
> > commit ff3dc8fefe953fd3650279e064bf63b212c5699a
> > Author: Daniel P. Berrangé <berrange@redhat.com>
> > Date:   Wed Mar 13 17:36:18 2019 +0000
> > 
> >     filemon: ensure watch IDs are unique to QFileMonitor scope  
> 
> [snip]
> 
> > I can try to collect extra info if you tell me what would be helpful.  
> 
> I'm betting you updated to kernel 5.3

Yeah, indeed... I would have been surprised if it were s390x-specific :)

> 
>   https://lists.gnu.org/archive/html/qemu-devel/2019-08/msg04349.html
> 
> Just waiting for a Reviewed-by on that patch in order to send a PR....

I'll take a look, but can't promise anything (first time looking at
that code path...)

> 
> Regards,
> Daniel