From: Cornelia Huck <cornelia.huck@mailbox.org>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, Peter Xu <peterx@redhat.com>,
Wei Yang <richardw.yang@linux.intel.com>
Subject: Re: [Qemu-devel] [PATCH] tests: make filemonitor test more robust to event ordering
Date: Thu, 22 Aug 2019 18:21:37 +0200 [thread overview]
Message-ID: <20190822182137.0f8ed9d2.cornelia.huck@mailbox.org> (raw)
In-Reply-To: <20190821155327.25208-1-berrange@redhat.com>
On Wed, 21 Aug 2019 16:53:27 +0100
Daniel P. Berrangé <berrange@redhat.com> wrote:
> The ordering of events that are emitted during the rmdir
> test have changed with kernel >= 5.3. Semantically both
> new & old orderings are correct, so we must be able to
> cope with either.
>
> To cope with this, when we see an unexpected event, we
> push it back onto the queue and look and the subsequent
> event to see if that matches instead.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> tests/test-util-filemonitor.c | 43 +++++++++++++++++++++++++++--------
> 1 file changed, 34 insertions(+), 9 deletions(-)
Tested-by: Cornelia Huck <cohuck@redhat.com>
I tried to review this patch, but I fear I'm out of my depth here :(
next prev parent reply other threads:[~2019-08-22 16:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 15:53 [Qemu-devel] [PATCH] tests: make filemonitor test more robust to event ordering Daniel P. Berrangé
2019-08-22 0:35 ` Wei Yang
2019-08-22 3:37 ` Peter Xu
2019-08-22 16:21 ` Cornelia Huck [this message]
2019-09-04 10:10 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190822182137.0f8ed9d2.cornelia.huck@mailbox.org \
--to=cornelia.huck@mailbox.org \
--cc=berrange@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richardw.yang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).