From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7979C3A5A3 for ; Tue, 27 Aug 2019 20:09:29 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AA8982186A for ; Tue, 27 Aug 2019 20:09:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AA8982186A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57340 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i2hmS-0001XT-N4 for qemu-devel@archiver.kernel.org; Tue, 27 Aug 2019 16:09:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46853) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i2hlB-0000aJ-IQ for qemu-devel@nongnu.org; Tue, 27 Aug 2019 16:08:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i2hl8-00034B-A4 for qemu-devel@nongnu.org; Tue, 27 Aug 2019 16:08:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41786) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i2hl6-00030v-RJ for qemu-devel@nongnu.org; Tue, 27 Aug 2019 16:08:06 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 33AFF1801582; Tue, 27 Aug 2019 20:08:02 +0000 (UTC) Received: from localhost (ovpn-116-73.gru2.redhat.com [10.97.116.73]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5D4B9600D1; Tue, 27 Aug 2019 20:08:01 +0000 (UTC) Date: Tue, 27 Aug 2019 17:07:59 -0300 From: Eduardo Habkost To: Cleber Rosa Message-ID: <20190827200759.GD7077@habkost.net> References: <20190826155832.17427-1-crosa@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190826155832.17427-1-crosa@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.63]); Tue, 27 Aug 2019 20:08:02 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH v2] configure: more resilient Python version capture X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Julio Montes , Peter Maydell , qemu-devel@nongnu.org, tony.nguyen@bt.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Aug 26, 2019 at 11:58:32AM -0400, Cleber Rosa wrote: > The current approach to capture the Python version is fragile, as it > was demonstrated by a very specific build of Python 3 on Fedora 29 > that, under non-interactive shells would print multiline version > information. > > The (badly) stripped version output would be sent to config-host.mak, > producing bad syntax and rendering the makefiles unusable. Now, the > Python versions is printed by configure, but only a simple (and better > controlled variable) indicating whether the build system is using > Python 2 is kept on config-host.mak. > > Signed-off-by: Cleber Rosa Queued, thanks! -- Eduardo