From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5B80C3A5A1 for ; Wed, 28 Aug 2019 07:20:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9CB8E217F5 for ; Wed, 28 Aug 2019 07:20:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CB8E217F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33310 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i2sGI-00070x-NW for qemu-devel@archiver.kernel.org; Wed, 28 Aug 2019 03:20:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48474) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i2sF9-0006TJ-Lk for qemu-devel@nongnu.org; Wed, 28 Aug 2019 03:19:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i2sF8-0005oo-Q7 for qemu-devel@nongnu.org; Wed, 28 Aug 2019 03:19:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45540) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i2sF8-0005oh-Kv; Wed, 28 Aug 2019 03:19:46 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CB20D1029A84; Wed, 28 Aug 2019 07:19:45 +0000 (UTC) Received: from gondolin (ovpn-116-220.ams2.redhat.com [10.36.116.220]) by smtp.corp.redhat.com (Postfix) with ESMTP id B9859600D1; Wed, 28 Aug 2019 07:19:40 +0000 (UTC) Date: Wed, 28 Aug 2019 09:19:37 +0200 From: Cornelia Huck To: David Hildenbrand Message-ID: <20190828091937.444d79d7.cohuck@redhat.com> In-Reply-To: <20190826075112.25637-3-david@redhat.com> References: <20190826075112.25637-1-david@redhat.com> <20190826075112.25637-3-david@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.66]); Wed, 28 Aug 2019 07:19:45 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH v2 2/7] s390x/tcg: Fix length calculation in probe_write_access() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , Eduardo Habkost , Aleksandar Rikalo , Riku Voipio , Richard Henderson , qemu-devel@nongnu.org, Aleksandar Markovic , qemu-s390x@nongnu.org, Paolo Bonzini , Aurelien Jarno , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 26 Aug 2019 09:51:07 +0200 David Hildenbrand wrote: > Hm... how did that "-" slip in (-TAGRET_PAGE_SIZE would be correct). This s/TAGRET/TARGET/ > currently makes us exceed one page in a single probe_write() call, > essentially leaving some memory unchecked. > > Fixes: c5a7392cfb96 ("s390x/tcg: Provide probe_write_access helper") > Reviewed-by: Richard Henderson > Signed-off-by: David Hildenbrand > --- > target/s390x/mem_helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Cornelia Huck