From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F850C3A5A1 for ; Wed, 28 Aug 2019 12:55:16 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 05F3E22CF5 for ; Wed, 28 Aug 2019 12:55:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 05F3E22CF5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36030 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i2xTn-0008No-4Z for qemu-devel@archiver.kernel.org; Wed, 28 Aug 2019 08:55:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58036) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i2xSn-0007ob-HN for qemu-devel@nongnu.org; Wed, 28 Aug 2019 08:54:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i2xSl-0006fM-Kf for qemu-devel@nongnu.org; Wed, 28 Aug 2019 08:54:13 -0400 Received: from 2.mo3.mail-out.ovh.net ([46.105.75.36]:60354) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i2xSl-0006cc-EK for qemu-devel@nongnu.org; Wed, 28 Aug 2019 08:54:11 -0400 Received: from player715.ha.ovh.net (unknown [10.108.35.223]) by mo3.mail-out.ovh.net (Postfix) with ESMTP id 4F0E4222E39 for ; Wed, 28 Aug 2019 14:54:09 +0200 (CEST) Received: from kaod.org (lns-bzn-46-82-253-208-248.adsl.proxad.net [82.253.208.248]) (Authenticated sender: groug@kaod.org) by player715.ha.ovh.net (Postfix) with ESMTPSA id 1516490635F4; Wed, 28 Aug 2019 12:54:04 +0000 (UTC) Date: Wed, 28 Aug 2019 14:54:03 +0200 From: Greg Kurz To: Alexey Kardashevskiy Message-ID: <20190828145403.1dcdafab@bahia.lan> In-Reply-To: <20190719043734.108462-1-aik@ozlabs.ru> References: <20190719043734.108462-1-aik@ozlabs.ru> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Ovh-Tracer-Id: 8750494079175006709 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddrudeitddgheejucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddm X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 46.105.75.36 Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH qemu v3] spapr_pci: Advertise BAR reallocation capability X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 19 Jul 2019 14:37:34 +1000 Alexey Kardashevskiy wrote: > The pseries guests do not normally allocate PCI resources and rely on > the system firmware doing so. Furthermore at least at some point in > the past the pseries guests won't even allowed to change BARs, probably > it is still the case for phyp. So since the initial commit we have [1] > which prevents resource reallocation. > > This is not a problem until we want specific BAR alignments, for example, > PAGE_SIZE==64k to make sure we can still map MMIO BARs directly. For > the boot time devices we handle this in SLOF [2] but since QEMU's RTAS > does not allocate BARs, the guest does this instead and does not align > BARs even if Linux is given pci=resource_alignment=16@pci:0:0 as > PCI_PROBE_ONLY makes Linux ignore alignment requests. > > ARM folks added a dial to control PCI_PROBE_ONLY via the device tree [3]. > This makes use of the dial to advertise to the guest that we can handle > BAR reassignments. This limits the change to the latest pseries machine > to avoid old guests explosion. > > We do not remove the flag from [1] as pseries guests are still supported > under phyp so having that removed may cause problems. > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/powerpc/platforms/pseries/setup.c?h=v5.1#n773 > [2] https://git.qemu.org/?p=SLOF.git;a=blob;f=board-qemu/slof/pci-phb.fs;h=06729bcf77a0d4e900c527adcd9befe2a269f65d;hb=HEAD#l338 > [3] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f81c11af > Signed-off-by: Alexey Kardashevskiy > --- LGTM Reviewed-by: Greg Kurz Alexey, I only received David's answer in my INBOX... I'm afraid you'll receive a yet another bounce from OVH's MX :-\ Since OVH seems to be ignoring the issue, maybe this could be worked around if you configure your postfix to relay mails to kaod.org through some other relay ? Cheers, -- Greg > Changes: > v3: > * moved the default setting to spapr_machine_class_init() > > v2: > * limited the change by a machine version > --- > include/hw/ppc/spapr.h | 1 + > hw/ppc/spapr.c | 9 +++++++++ > 2 files changed, 10 insertions(+) > > diff --git a/include/hw/ppc/spapr.h b/include/hw/ppc/spapr.h > index c79bc6a1232b..ebbd92673b34 100644 > --- a/include/hw/ppc/spapr.h > +++ b/include/hw/ppc/spapr.h > @@ -121,6 +121,7 @@ struct SpaprMachineClass { > bool legacy_irq_allocation; > bool broken_host_serial_model; /* present real host info to the guest */ > bool pre_4_1_migration; /* don't migrate hpt-max-page-size */ > + bool linux_pci_probe; > > void (*phb_placement)(SpaprMachineState *spapr, uint32_t index, > uint64_t *buid, hwaddr *pio, > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > index 2ee671e55e0c..4bff0cf90d4b 100644 > --- a/hw/ppc/spapr.c > +++ b/hw/ppc/spapr.c > @@ -1164,6 +1164,7 @@ static void spapr_dt_ov5_platform_support(SpaprMachineState *spapr, void *fdt, > static void spapr_dt_chosen(SpaprMachineState *spapr, void *fdt) > { > MachineState *machine = MACHINE(spapr); > + SpaprMachineClass *smc = SPAPR_MACHINE_GET_CLASS(machine); > int chosen; > const char *boot_device = machine->boot_order; > char *stdout_path = spapr_vio_stdout_path(spapr->vio_bus); > @@ -1221,6 +1222,11 @@ static void spapr_dt_chosen(SpaprMachineState *spapr, void *fdt) > _FDT(fdt_setprop_string(fdt, chosen, "stdout-path", stdout_path)); > } > > + /* We can deal with BAR reallocation just fine, advertise it to the guest */ > + if (smc->linux_pci_probe) { > + _FDT(fdt_setprop_cell(fdt, chosen, "linux,pci-probe-only", 0)); > + } > + > spapr_dt_ov5_platform_support(spapr, fdt, chosen); > > g_free(stdout_path); > @@ -4467,6 +4473,7 @@ static void spapr_machine_class_init(ObjectClass *oc, void *data) > spapr_caps_add_properties(smc, &error_abort); > smc->irq = &spapr_irq_dual; > smc->dr_phb_enabled = true; > + smc->linux_pci_probe = true; > } > > static const TypeInfo spapr_machine_info = { > @@ -4526,12 +4533,14 @@ DEFINE_SPAPR_MACHINE(4_2, "4.2", true); > */ > static void spapr_machine_4_1_class_options(MachineClass *mc) > { > + SpaprMachineClass *smc = SPAPR_MACHINE_CLASS(mc); > static GlobalProperty compat[] = { > /* Only allow 4kiB and 64kiB IOMMU pagesizes */ > { TYPE_SPAPR_PCI_HOST_BRIDGE, "pgsz", "0x11000" }, > }; > > spapr_machine_4_2_class_options(mc); > + smc->linux_pci_probe = false; > compat_props_add(mc->compat_props, compat, G_N_ELEMENTS(compat)); > } >