From: Cornelia Huck <cohuck@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
qemu-s390x@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] pc-bios/s390-ccw: Do not pre-initialize empty array
Date: Wed, 28 Aug 2019 15:47:25 +0200 [thread overview]
Message-ID: <20190828154725.5dca8d1f.cohuck@redhat.com> (raw)
In-Reply-To: <f213c73c-61d8-6333-edb8-c8f988a5bd9a@redhat.com>
On Wed, 28 Aug 2019 15:42:37 +0200
Thomas Huth <thuth@redhat.com> wrote:
> On 28/08/2019 15.27, Christian Borntraeger wrote:
> > On 28.08.19 14:33, Thomas Huth wrote:
> >> We're clearing the BSS in start.S now, so there is no need to
> >> pre-initialize the loadparm_str array with zeroes anymore.
> >
> > Can you add a link to the commit that does the bss clearing?
>
> Sure, I'll change the description to:
>
> "
> Since commit 339686a358b11a231aa5b6d1424e7a1460d7f277 ("pc-bios/s390-ccw:
> zero out bss section"), we are clearing now the BSS in start.S, so there
> is no need to pre-initialize the loadparm_str array with zeroes anymore.
> "
>
> Thomas
With that:
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
next prev parent reply other threads:[~2019-08-28 13:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 12:33 [Qemu-devel] [PATCH] pc-bios/s390-ccw: Do not pre-initialize empty array Thomas Huth
2019-08-28 13:27 ` Christian Borntraeger
2019-08-28 13:42 ` Thomas Huth
2019-08-28 13:47 ` Cornelia Huck [this message]
2019-08-28 13:48 ` [Qemu-devel] [qemu-s390x] " Christian Borntraeger
2019-08-28 13:52 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190828154725.5dca8d1f.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).