qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Mark Kanda <mark.kanda@oracle.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH-for-4.2 v2] Only enable the halt poll control MSR if it is supported by the host
Date: Wed, 28 Aug 2019 15:22:03 -0300	[thread overview]
Message-ID: <20190828182202.GA21924@amt.cnet> (raw)
In-Reply-To: <277b5916-4e46-1aef-6368-a414de4d2149@oracle.com>

On Wed, Aug 28, 2019 at 12:22:59PM -0500, Mark Kanda wrote:
> Gentle ping - I would like to confirm this patch is acceptable.
> 
> Thanks/regards,
> -Mark

ACK

> 
> On 7/17/2019 9:38 AM, Mark Kanda wrote:
> >The halt poll control MSR should only be enabled on hosts which
> >support it.
> >
> >Fixes: ("kvm: i386: halt poll control MSR support")
> >
> >Signed-off-by: Mark Kanda <mark.kanda@oracle.com>
> >
> >---
> >v2: Remove unnecessary hunks which break migration with older hosts (Paolo)
> >---
> >  target/i386/cpu.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> >diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> >index a8bafdb8b9..543bc25f64 100644
> >--- a/target/i386/cpu.c
> >+++ b/target/i386/cpu.c
> >@@ -2838,7 +2838,6 @@ static PropValue kvm_default_props[] = {
> >      { "kvm-asyncpf", "on" },
> >      { "kvm-steal-time", "on" },
> >      { "kvm-pv-eoi", "on" },
> >-    { "kvm-poll-control", "on" },
> >      { "kvmclock-stable-bit", "on" },
> >      { "x2apic", "on" },
> >      { "acpi", "off" },
> >


  reply	other threads:[~2019-08-28 18:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-17 14:38 [Qemu-devel] [PATCH-for-4.2 v2] Only enable the halt poll control MSR if it is supported by the host Mark Kanda
2019-08-28 17:22 ` Mark Kanda
2019-08-28 18:22   ` Marcelo Tosatti [this message]
2019-09-09 17:28   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190828182202.GA21924@amt.cnet \
    --to=mtosatti@redhat.com \
    --cc=mark.kanda@oracle.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).