* [Qemu-devel] [PATCH-for-4.2 v2] Only enable the halt poll control MSR if it is supported by the host
@ 2019-07-17 14:38 Mark Kanda
2019-08-28 17:22 ` Mark Kanda
0 siblings, 1 reply; 4+ messages in thread
From: Mark Kanda @ 2019-07-17 14:38 UTC (permalink / raw)
To: qemu-devel; +Cc: pbonzini, mtosatti
The halt poll control MSR should only be enabled on hosts which
support it.
Fixes: ("kvm: i386: halt poll control MSR support")
Signed-off-by: Mark Kanda <mark.kanda@oracle.com>
---
v2: Remove unnecessary hunks which break migration with older hosts (Paolo)
---
target/i386/cpu.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index a8bafdb8b9..543bc25f64 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -2838,7 +2838,6 @@ static PropValue kvm_default_props[] = {
{ "kvm-asyncpf", "on" },
{ "kvm-steal-time", "on" },
{ "kvm-pv-eoi", "on" },
- { "kvm-poll-control", "on" },
{ "kvmclock-stable-bit", "on" },
{ "x2apic", "on" },
{ "acpi", "off" },
--
2.21.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH-for-4.2 v2] Only enable the halt poll control MSR if it is supported by the host
2019-07-17 14:38 [Qemu-devel] [PATCH-for-4.2 v2] Only enable the halt poll control MSR if it is supported by the host Mark Kanda
@ 2019-08-28 17:22 ` Mark Kanda
2019-08-28 18:22 ` Marcelo Tosatti
2019-09-09 17:28 ` Paolo Bonzini
0 siblings, 2 replies; 4+ messages in thread
From: Mark Kanda @ 2019-08-28 17:22 UTC (permalink / raw)
To: qemu-devel; +Cc: pbonzini, mtosatti
Gentle ping - I would like to confirm this patch is acceptable.
Thanks/regards,
-Mark
On 7/17/2019 9:38 AM, Mark Kanda wrote:
> The halt poll control MSR should only be enabled on hosts which
> support it.
>
> Fixes: ("kvm: i386: halt poll control MSR support")
>
> Signed-off-by: Mark Kanda <mark.kanda@oracle.com>
>
> ---
> v2: Remove unnecessary hunks which break migration with older hosts (Paolo)
> ---
> target/i386/cpu.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> index a8bafdb8b9..543bc25f64 100644
> --- a/target/i386/cpu.c
> +++ b/target/i386/cpu.c
> @@ -2838,7 +2838,6 @@ static PropValue kvm_default_props[] = {
> { "kvm-asyncpf", "on" },
> { "kvm-steal-time", "on" },
> { "kvm-pv-eoi", "on" },
> - { "kvm-poll-control", "on" },
> { "kvmclock-stable-bit", "on" },
> { "x2apic", "on" },
> { "acpi", "off" },
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH-for-4.2 v2] Only enable the halt poll control MSR if it is supported by the host
2019-08-28 17:22 ` Mark Kanda
@ 2019-08-28 18:22 ` Marcelo Tosatti
2019-09-09 17:28 ` Paolo Bonzini
1 sibling, 0 replies; 4+ messages in thread
From: Marcelo Tosatti @ 2019-08-28 18:22 UTC (permalink / raw)
To: Mark Kanda; +Cc: pbonzini, qemu-devel
On Wed, Aug 28, 2019 at 12:22:59PM -0500, Mark Kanda wrote:
> Gentle ping - I would like to confirm this patch is acceptable.
>
> Thanks/regards,
> -Mark
ACK
>
> On 7/17/2019 9:38 AM, Mark Kanda wrote:
> >The halt poll control MSR should only be enabled on hosts which
> >support it.
> >
> >Fixes: ("kvm: i386: halt poll control MSR support")
> >
> >Signed-off-by: Mark Kanda <mark.kanda@oracle.com>
> >
> >---
> >v2: Remove unnecessary hunks which break migration with older hosts (Paolo)
> >---
> > target/i386/cpu.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> >diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> >index a8bafdb8b9..543bc25f64 100644
> >--- a/target/i386/cpu.c
> >+++ b/target/i386/cpu.c
> >@@ -2838,7 +2838,6 @@ static PropValue kvm_default_props[] = {
> > { "kvm-asyncpf", "on" },
> > { "kvm-steal-time", "on" },
> > { "kvm-pv-eoi", "on" },
> >- { "kvm-poll-control", "on" },
> > { "kvmclock-stable-bit", "on" },
> > { "x2apic", "on" },
> > { "acpi", "off" },
> >
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH-for-4.2 v2] Only enable the halt poll control MSR if it is supported by the host
2019-08-28 17:22 ` Mark Kanda
2019-08-28 18:22 ` Marcelo Tosatti
@ 2019-09-09 17:28 ` Paolo Bonzini
1 sibling, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2019-09-09 17:28 UTC (permalink / raw)
To: Mark Kanda, qemu-devel; +Cc: mtosatti
On 28/08/19 19:22, Mark Kanda wrote:
> Gentle ping - I would like to confirm this patch is acceptable.
Yes, it was squashed in Marcelo's patch (commit
d645e1328726b38b3c79525eb57842ce29c1df7c).
Paolo
> Thanks/regards,
> -Mark
>
> On 7/17/2019 9:38 AM, Mark Kanda wrote:
>> The halt poll control MSR should only be enabled on hosts which
>> support it.
>>
>> Fixes: ("kvm: i386: halt poll control MSR support")
>>
>> Signed-off-by: Mark Kanda <mark.kanda@oracle.com>
>>
>> ---
>> v2: Remove unnecessary hunks which break migration with older hosts
>> (Paolo)
>> ---
>> target/i386/cpu.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
>> index a8bafdb8b9..543bc25f64 100644
>> --- a/target/i386/cpu.c
>> +++ b/target/i386/cpu.c
>> @@ -2838,7 +2838,6 @@ static PropValue kvm_default_props[] = {
>> { "kvm-asyncpf", "on" },
>> { "kvm-steal-time", "on" },
>> { "kvm-pv-eoi", "on" },
>> - { "kvm-poll-control", "on" },
>> { "kvmclock-stable-bit", "on" },
>> { "x2apic", "on" },
>> { "acpi", "off" },
>>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-09-09 17:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-17 14:38 [Qemu-devel] [PATCH-for-4.2 v2] Only enable the halt poll control MSR if it is supported by the host Mark Kanda
2019-08-28 17:22 ` Mark Kanda
2019-08-28 18:22 ` Marcelo Tosatti
2019-09-09 17:28 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).