qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
	Igor Mammedov <imammedo@redhat.com>,
	qemu-devel@nongnu.org,
	Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
	Richard Henderson <rth@twiddle.net>,
	Peter Maydell <peter.maydell@linaro.org>
Cc: Jan Kiszka <jan.kiszka@siemens.com>
Subject: [Qemu-devel] [PULL v6 12/12] i386/vmmouse: Properly reset state
Date: Wed, 28 Aug 2019 15:40:26 -0300	[thread overview]
Message-ID: <20190828184026.5840-13-ehabkost@redhat.com> (raw)
In-Reply-To: <20190828184026.5840-1-ehabkost@redhat.com>

From: Jan Kiszka <jan.kiszka@siemens.com>

nb_queue was not zeroed so that we no longer delivered events if a
previous guest left the device in an overflow state.

The state of absolute does not matter as the next vmmouse_update_handler
call will align it again.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Message-Id: <f056c7e5-fa74-469c-87f8-0f0925301b2d@web.de>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 hw/i386/vmmouse.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/i386/vmmouse.c b/hw/i386/vmmouse.c
index 012ab90396..41ad91ad53 100644
--- a/hw/i386/vmmouse.c
+++ b/hw/i386/vmmouse.c
@@ -258,6 +258,7 @@ static void vmmouse_reset(DeviceState *d)
     VMMouseState *s = VMMOUSE(d);
 
     s->queue_size = VMMOUSE_QUEUE_SIZE;
+    s->nb_queue = 0;
 
     vmmouse_disable(s);
 }
-- 
2.21.0



  parent reply	other threads:[~2019-08-28 18:46 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-28 18:40 [Qemu-devel] [PULL v6 00/12] Machine + x86 queue, 2019-08-28 Eduardo Habkost
2019-08-28 18:40 ` [Qemu-devel] [PULL v6 01/12] includes: remove stale [smp|max]_cpus externs Eduardo Habkost
2019-08-28 18:40 ` [Qemu-devel] [PULL v6 02/12] hw/arm: simplify arm_load_dtb Eduardo Habkost
2019-08-28 18:40 ` [Qemu-devel] [PULL v6 03/12] numa: move numa global variable nb_numa_nodes into MachineState Eduardo Habkost
2019-08-28 18:40 ` [Qemu-devel] [PULL v6 04/12] numa: move numa global variable have_numa_distance " Eduardo Habkost
2019-08-28 18:40 ` [Qemu-devel] [PULL v6 05/12] numa: move numa global variable numa_info " Eduardo Habkost
2019-08-28 18:40 ` [Qemu-devel] [PULL v6 06/12] numa: Introduce MachineClass::auto_enable_numa for implicit NUMA node Eduardo Habkost
2019-08-28 18:40 ` [Qemu-devel] [PULL v6 07/12] pc: Fix error message on die-id validation Eduardo Habkost
2019-08-28 18:40 ` [Qemu-devel] [PULL v6 08/12] pc: Improve error message when die-id is omitted Eduardo Habkost
2019-08-28 18:40 ` [Qemu-devel] [PULL v6 09/12] pc: Don't make die-id mandatory unless necessary Eduardo Habkost
2019-08-28 18:40 ` [Qemu-devel] [PULL v6 10/12] qapi: report the default CPU type for each machine Eduardo Habkost
2019-08-28 18:40 ` [Qemu-devel] [PULL v6 11/12] hostmem-file: fix pmem file size check Eduardo Habkost
2019-08-28 18:40 ` Eduardo Habkost [this message]
2019-09-03 15:03 ` [Qemu-devel] [PULL v6 00/12] Machine + x86 queue, 2019-08-28 Peter Maydell
2019-09-03 19:27   ` Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190828184026.5840-13-ehabkost@redhat.com \
    --to=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).