* [Qemu-devel] [PATCH] linux-user: fail and report on bad dfilter specs
@ 2019-08-30 14:36 Alex Bennée
2019-08-30 14:37 ` Laurent Vivier
0 siblings, 1 reply; 4+ messages in thread
From: Alex Bennée @ 2019-08-30 14:36 UTC (permalink / raw)
To: qemu-devel; +Cc: Riku Voipio, Alex Bennée, Laurent Vivier
Just passing NULL means we end up ignoring the bad dfilter spec
instead of reporting it and exiting as we should.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
linux-user/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/linux-user/main.c b/linux-user/main.c
index 47917bbb20f..50a031520ca 100644
--- a/linux-user/main.c
+++ b/linux-user/main.c
@@ -236,7 +236,7 @@ static void handle_arg_log(const char *arg)
static void handle_arg_dfilter(const char *arg)
{
- qemu_set_dfilter_ranges(arg, NULL);
+ qemu_set_dfilter_ranges(arg, &error_fatal);
}
static void handle_arg_log_filename(const char *arg)
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] linux-user: fail and report on bad dfilter specs
2019-08-30 14:36 [Qemu-devel] [PATCH] linux-user: fail and report on bad dfilter specs Alex Bennée
@ 2019-08-30 14:37 ` Laurent Vivier
2019-09-09 14:00 ` Alex Bennée
0 siblings, 1 reply; 4+ messages in thread
From: Laurent Vivier @ 2019-08-30 14:37 UTC (permalink / raw)
To: Alex Bennée, qemu-devel; +Cc: Riku Voipio
Le 30/08/2019 à 16:36, Alex Bennée a écrit :
> Just passing NULL means we end up ignoring the bad dfilter spec
> instead of reporting it and exiting as we should.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> linux-user/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/linux-user/main.c b/linux-user/main.c
> index 47917bbb20f..50a031520ca 100644
> --- a/linux-user/main.c
> +++ b/linux-user/main.c
> @@ -236,7 +236,7 @@ static void handle_arg_log(const char *arg)
>
> static void handle_arg_dfilter(const char *arg)
> {
> - qemu_set_dfilter_ranges(arg, NULL);
> + qemu_set_dfilter_ranges(arg, &error_fatal);
> }
>
> static void handle_arg_log_filename(const char *arg)
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] linux-user: fail and report on bad dfilter specs
2019-08-30 14:37 ` Laurent Vivier
@ 2019-09-09 14:00 ` Alex Bennée
2019-09-09 14:05 ` Laurent Vivier
0 siblings, 1 reply; 4+ messages in thread
From: Alex Bennée @ 2019-09-09 14:00 UTC (permalink / raw)
To: Laurent Vivier; +Cc: Riku Voipio, qemu-devel
Laurent Vivier <laurent@vivier.eu> writes:
> Le 30/08/2019 à 16:36, Alex Bennée a écrit :
>> Just passing NULL means we end up ignoring the bad dfilter spec
>> instead of reporting it and exiting as we should.
>>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> ---
>> linux-user/main.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/linux-user/main.c b/linux-user/main.c
>> index 47917bbb20f..50a031520ca 100644
>> --- a/linux-user/main.c
>> +++ b/linux-user/main.c
>> @@ -236,7 +236,7 @@ static void handle_arg_log(const char *arg)
>>
>> static void handle_arg_dfilter(const char *arg)
>> {
>> - qemu_set_dfilter_ranges(arg, NULL);
>> + qemu_set_dfilter_ranges(arg, &error_fatal);
>> }
>>
>> static void handle_arg_log_filename(const char *arg)
>>
>
> Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Did you queue this or do you want me to resend?
--
Alex Bennée
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] linux-user: fail and report on bad dfilter specs
2019-09-09 14:00 ` Alex Bennée
@ 2019-09-09 14:05 ` Laurent Vivier
0 siblings, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2019-09-09 14:05 UTC (permalink / raw)
To: Alex Bennée; +Cc: Riku Voipio, qemu-devel
Le 09/09/2019 à 16:00, Alex Bennée a écrit :
>
> Laurent Vivier <laurent@vivier.eu> writes:
>
>> Le 30/08/2019 à 16:36, Alex Bennée a écrit :
>>> Just passing NULL means we end up ignoring the bad dfilter spec
>>> instead of reporting it and exiting as we should.
>>>
>>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>>> ---
>>> linux-user/main.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/linux-user/main.c b/linux-user/main.c
>>> index 47917bbb20f..50a031520ca 100644
>>> --- a/linux-user/main.c
>>> +++ b/linux-user/main.c
>>> @@ -236,7 +236,7 @@ static void handle_arg_log(const char *arg)
>>>
>>> static void handle_arg_dfilter(const char *arg)
>>> {
>>> - qemu_set_dfilter_ranges(arg, NULL);
>>> + qemu_set_dfilter_ranges(arg, &error_fatal);
>>> }
>>>
>>> static void handle_arg_log_filename(const char *arg)
>>>
>>
>> Reviewed-by: Laurent Vivier <laurent@vivier.eu>
>
> Did you queue this or do you want me to resend?
I didn't but it's done now (no need to resend).
Thanks,
Laurent
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-09-09 14:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-30 14:36 [Qemu-devel] [PATCH] linux-user: fail and report on bad dfilter specs Alex Bennée
2019-08-30 14:37 ` Laurent Vivier
2019-09-09 14:00 ` Alex Bennée
2019-09-09 14:05 ` Laurent Vivier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).