From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80A6EC3A59E for ; Mon, 2 Sep 2019 13:19:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 527AE208CB for ; Mon, 2 Sep 2019 13:19:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 527AE208CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36444 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i4mF2-0003Po-9U for qemu-devel@archiver.kernel.org; Mon, 02 Sep 2019 09:19:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50054) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i4mCo-0001qX-UL for qemu-devel@nongnu.org; Mon, 02 Sep 2019 09:17:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i4mCo-0007BD-3e for qemu-devel@nongnu.org; Mon, 02 Sep 2019 09:17:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60306) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i4mCk-00072W-0v; Mon, 02 Sep 2019 09:17:10 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AE7C23082B45; Mon, 2 Sep 2019 13:17:08 +0000 (UTC) Received: from localhost.localdomain (ovpn-116-189.ams2.redhat.com [10.36.116.189]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 270275C578; Mon, 2 Sep 2019 13:17:02 +0000 (UTC) Date: Mon, 2 Sep 2019 15:17:01 +0200 From: Kevin Wolf To: Max Reitz Message-ID: <20190902131701.GF13140@localhost.localdomain> References: <20190823130341.21550-1-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190823130341.21550-1-mreitz@redhat.com> User-Agent: Mutt/1.11.3 (2019-02-01) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Mon, 02 Sep 2019 13:17:08 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH 0/2] block/file-posix: Reduce xfsctl() use X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?B?THVrw6HFoQ==?= Doktor , Paolo Bonzini , qemu-devel@nongnu.org, qemu-block@nongnu.org, qemu-stable@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 23.08.2019 um 15:03 hat Max Reitz geschrieben: > Hi, >=20 > As suggested by Paolo, this series drops xfsctl() calls where we have > working fallocate() alternatives. (And thus replaces =E2=80=9Cblock/fi= le-posix: > Fix xfs_write_zeroes()=E2=80=9D.) >=20 > Unfortunately, we also use xfsctl() to inquire the request alignment fo= r > O_DIRECT, and this is the only way we currently have to obtain it > without trying. Therefore, I didn=E2=80=99t quite like removing that c= all, too, > so this series doesn=E2=80=99t get rid of xfsctl() completely. >=20 > (If we did, we could delete 146 lines instead of these measly 76 here.) >=20 >=20 > Anyway, dropping xfs_write_zeroes() will also fix the guest corruptions > Luk=C3=A1=C5=A1 has reported (for qcow2, but I think it should be possi= ble to see > similar corruptions with raw, although I haven=E2=80=99t investigated t= hat too > far). Thanks, applied to the block branch. Kevin