qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: virtio-fs@redhat.com,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 4/4] virtiofsd: add vhost-user.json file
Date: Tue, 3 Sep 2019 18:31:12 +0100	[thread overview]
Message-ID: <20190903173112.GU2744@work-vm> (raw)
In-Reply-To: <20190827095437.18819-5-stefanha@redhat.com>

* Stefan Hajnoczi (stefanha@redhat.com) wrote:
> Install a vhost-user.json file describing virtiofsd.  This allows
> libvirt and other management tools to enumerate vhost-user backend
> programs.
> 
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

> ---
>  Makefile                                    | 1 +
>  .gitignore                                  | 1 +
>  contrib/virtiofsd/50-qemu-virtiofsd.json.in | 5 +++++
>  3 files changed, 7 insertions(+)
>  create mode 100644 contrib/virtiofsd/50-qemu-virtiofsd.json.in
> 
> diff --git a/Makefile b/Makefile
> index ef6eca07cc..c6e2f4e7a0 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -318,6 +318,7 @@ HELPERS-$(call land,$(CONFIG_SOFTMMU),$(CONFIG_LINUX)) = qemu-bridge-helper$(EXE
>  
>  ifdef CONFIG_LINUX
>  HELPERS-y += virtiofsd$(EXESUF)
> +vhost-user-json-y += contrib/virtiofsd/50-qemu-virtiofsd.json
>  
>  ifdef CONFIG_VIRGL
>  ifdef CONFIG_GBM
> diff --git a/.gitignore b/.gitignore
> index fd6e6c38c7..554c7abe81 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -6,6 +6,7 @@
>  /config-target.*
>  /config.status
>  /config-temp
> +/contrib/virtiofsd/50-qemu-virtiofsd.json
>  /elf2dmp
>  /trace-events-all
>  /trace/generated-events.h
> diff --git a/contrib/virtiofsd/50-qemu-virtiofsd.json.in b/contrib/virtiofsd/50-qemu-virtiofsd.json.in
> new file mode 100644
> index 0000000000..9bcd86f8dc
> --- /dev/null
> +++ b/contrib/virtiofsd/50-qemu-virtiofsd.json.in
> @@ -0,0 +1,5 @@
> +{
> +  "description": "QEMU virtiofsd vhost-user-fs",
> +  "type": "fs",
> +  "binary": "@libexecdir@/virtiofsd"
> +}
> -- 
> 2.21.0
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK


  reply	other threads:[~2019-09-03 17:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-27  9:54 [Qemu-devel] [PATCH 0/4] virtiofsd: implement vhost-user.rst "Backend program conventions" Stefan Hajnoczi
2019-08-27  9:54 ` [Qemu-devel] [PATCH 1/4] virtiofsd: make -f (foreground) the default Stefan Hajnoczi
2019-09-03 17:17   ` Dr. David Alan Gilbert
2019-08-27  9:54 ` [Qemu-devel] [PATCH 2/4] virtiofsd: add --print-capabilities option Stefan Hajnoczi
2019-09-03 17:26   ` Dr. David Alan Gilbert
2019-09-04 15:51     ` Stefan Hajnoczi
2019-09-12 11:12       ` Stefan Hajnoczi
2019-09-12 12:40   ` Marc-André Lureau
2019-08-27  9:54 ` [Qemu-devel] [PATCH 3/4] virtiofsd: install virtiofsd in libexec Stefan Hajnoczi
2019-09-03 17:29   ` Dr. David Alan Gilbert
2019-08-27  9:54 ` [Qemu-devel] [PATCH 4/4] virtiofsd: add vhost-user.json file Stefan Hajnoczi
2019-09-03 17:31   ` Dr. David Alan Gilbert [this message]
2019-09-03 17:32 ` [Qemu-devel] [PATCH 0/4] virtiofsd: implement vhost-user.rst "Backend program conventions" Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190903173112.GU2744@work-vm \
    --to=dgilbert@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=virtio-fs@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).