From: Peter Xu <peterx@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Michael Roth" <mdroth@linux.vnet.ibm.com>,
qemu-block@nongnu.org, qemu-trivial@nongnu.org,
qemu-devel@nongnu.org, "Markus Armbruster" <armbru@redhat.com>,
"Max Reitz" <mreitz@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] cutils: Move size_to_str() from "qemu-common.h" to "qemu/cutils.h"
Date: Wed, 4 Sep 2019 10:16:03 +0800 [thread overview]
Message-ID: <20190904021603.GD30402@xz-x1> (raw)
In-Reply-To: <6aca73a4-1567-4952-14eb-ecd3c115acad@redhat.com>
On Tue, Sep 03, 2019 at 02:57:31PM -0400, John Snow wrote:
[...]
> Seems proper. It must be an oversight to begin with that we declared it
> in qemu-common but defined it in cutils.
Porbably true..
>
> Reviewed-by: John Snow <jsnow@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Thanks,
--
Peter Xu
next prev parent reply other threads:[~2019-09-04 2:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 12:05 [Qemu-devel] [PATCH] cutils: Move size_to_str() from "qemu-common.h" to "qemu/cutils.h" Philippe Mathieu-Daudé
2019-09-03 18:57 ` [Qemu-devel] [Qemu-block] " John Snow
2019-09-04 2:16 ` Peter Xu [this message]
2019-09-19 9:57 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190904021603.GD30402@xz-x1 \
--to=peterx@redhat.com \
--cc=armbru@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mreitz@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).