From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08752C3A5A8 for ; Wed, 4 Sep 2019 18:11:30 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D683A208E4 for ; Wed, 4 Sep 2019 18:11:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D683A208E4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36156 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i5Zke-0004m9-PH for qemu-devel@archiver.kernel.org; Wed, 04 Sep 2019 14:11:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56816) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i5Zjs-0004NC-Tp for qemu-devel@nongnu.org; Wed, 04 Sep 2019 14:10:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i5Zjq-00037A-96 for qemu-devel@nongnu.org; Wed, 04 Sep 2019 14:10:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59772) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i5Zjp-00036o-W4 for qemu-devel@nongnu.org; Wed, 04 Sep 2019 14:10:38 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 211121026FFB for ; Wed, 4 Sep 2019 18:10:37 +0000 (UTC) Received: from localhost (ovpn-116-88.ams2.redhat.com [10.36.116.88]) by smtp.corp.redhat.com (Postfix) with ESMTP id 59D6E5D70D; Wed, 4 Sep 2019 18:10:31 +0000 (UTC) Date: Wed, 4 Sep 2019 19:10:30 +0100 From: Stefan Hajnoczi To: "Dr. David Alan Gilbert" Message-ID: <20190904181030.GA26826@stefanha-x1.localdomain> References: <20190829104133.17418-1-stefanha@redhat.com> <20190903153539.GM2744@work-vm> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="45Z9DzgjV8m4Oswq" Content-Disposition: inline In-Reply-To: <20190903153539.GM2744@work-vm> User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.66]); Wed, 04 Sep 2019 18:10:37 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH] virtiofsd: add man page X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: virtio-fs@redhat.com, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --45Z9DzgjV8m4Oswq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 03, 2019 at 04:35:39PM +0100, Dr. David Alan Gilbert wrote: > * Stefan Hajnoczi (stefanha@redhat.com) wrote: > > Signed-off-by: Stefan Hajnoczi > > --- > > Makefile | 7 +++ > > contrib/virtiofsd/virtiofsd.texi | 85 ++++++++++++++++++++++++++++++++ > > 2 files changed, 92 insertions(+) > > create mode 100644 contrib/virtiofsd/virtiofsd.texi > >=20 > > diff --git a/Makefile b/Makefile > > index a3dfdd6fa8..cc18025753 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -334,6 +334,9 @@ DOCS+=3Ddocs/qemu-cpu-models.7 > > ifdef CONFIG_VIRTFS > > DOCS+=3Dfsdev/virtfs-proxy-helper.1 > > endif > > +ifdef CONFIG_LINUX >=20 > Is there a reason that's CONFIG_LINUX not CONFIG_VHOST_USER_FS ? > (Although I guess it's guest vs daemon so the two are independent?) Yes, this is virtiofsd, not vhost-user-fs-pci. We don't have a CONFIG_VIRTIOFSD. > > +DOCS+=3Dcontrib/virtiofsd/virtiofsd.1 > > +endif > > ifdef CONFIG_TRACE_SYSTEMTAP > > DOCS+=3Dscripts/qemu-trace-stap.1 > > endif > > @@ -834,6 +837,9 @@ ifdef CONFIG_VIRTFS > > $(INSTALL_DIR) "$(DESTDIR)$(mandir)/man1" > > $(INSTALL_DATA) fsdev/virtfs-proxy-helper.1 "$(DESTDIR)$(mandir)/man1" > > endif > > +ifdef CONFIG_LINUX > > + $(INSTALL_DATA) contrib/virtiofsd.1 "$(DESTDIR)$(mandir)/man1" >=20 > I had to fix that to contrib/virtiofsd/virtiofsd.1 to get make install > happy. Thanks for spotting it! > > +@c man begin DESCRIPTION > > + > > +Share a host directory tree with a guest through a virtio-fs device. = This > > +program is a vhost-user backend that implements the virtio-fs device. = Each > > +virtio-fs device instance requires its own virtiofsd process. > > + > > +This program is designed to work with QEMU's @code{--device vhost-user= -fs-pci} >=20 > Should we include the -pci there? >=20 > (Merged with the path fix above) We could also be more general and say "vhost-user virtio-fs device" to avoid the issue. Stefan --45Z9DzgjV8m4Oswq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAl1v/hYACgkQnKSrs4Gr c8jtAQgAna0dQRA6RKpt4vAGNm9rRvw0sQ7/Vua3kBzhTp6kQPk5W7VIpLh+HHcs STKfJ5Fvy7nH0FV8w9vrJmv6BsrP6/Jw3I2ZRv+I2/usHLA1sZRcYdX+a7nk3w+/ y1HkwJeG9NOkoYWBBEvUHN+aZlVcefypy1aH3NdSTTvi8vNcABXXu+vMfLVN/rGO h0nX/3mFs7IFYI3DY45wFT3fQavVo5tSo7pjM5WeIx3I3JppxdhxWtTMzQoBIpCC LcSZ8SX9Sxc6rNWWpAFtbCGAzrDCFpO0SdrrcownX2ryXvGeW8pD4Uz209VZUwIB tpANPWJpOghUCN1FeMl+BF9QEQOpFw== =NByF -----END PGP SIGNATURE----- --45Z9DzgjV8m4Oswq--