Re: [Qemu-devel] [PATCH v2 3/6] tests/libqos: Replace clock_step with qtest_clock_step in virtio code

[Stefan Hajnoczi <stefanha@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1037 bytes --]

On Wed, Sep 04, 2019 at 03:00:44PM +0200, Thomas Huth wrote:
> Library functions should not rely on functions that require global_qtest
> (since they might get used in tests that deal with multiple states).
> Commit 1999a70a05ad603d ("Make generic virtio code independent from
> global_qtest") already tried to clean the libqos virtio code, but I
> missed to replace the clock_step() function. Thus change it now to
> qtest_clock_step() instead.
> The logic of the qvirtio_wait_config_isr() function is now pushed
> to the virtio-mmio.c and virtio-pci.c files instead, since we can
> get the QTestState here easily.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  tests/libqos/virtio-mmio.c | 14 +++++++++++++-
>  tests/libqos/virtio-pci.c  | 14 +++++++++++++-
>  tests/libqos/virtio.c      | 20 ++++++--------------
>  tests/libqos/virtio.h      |  6 +++---
>  tests/virtio-blk-test.c    |  3 ++-
>  5 files changed, 37 insertions(+), 20 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]