From: Greg Kurz <groug@kaod.org>
To: Thomas Huth <thuth@redhat.com>
Cc: "Fam Zheng" <fam@euphon.net>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] travis.yml: Install libcap-dev for testing virito-9p
Date: Thu, 5 Sep 2019 14:18:48 +0200 [thread overview]
Message-ID: <20190905141848.331aba6c@bahia.lan> (raw)
In-Reply-To: <20190905140701.6cc679ee@bahia.lan>
On Thu, 5 Sep 2019 14:07:01 +0200
Greg Kurz <groug@kaod.org> wrote:
> On Thu, 5 Sep 2019 13:33:46 +0200
> Thomas Huth <thuth@redhat.com> wrote:
>
> > So far we were not testing virtio-9p in Travis yet, since we forgot to
> > install libcap-devel. Do it now to get some more test coverage.
> >
> > Signed-off-by: Thomas Huth <thuth@redhat.com>
> > ---
>
> Acked-by: Greg Kurz <groug@kaod.org>
>
Hmm... shouldn't libcap-dev be added in the "Acceptance (Functional) tests"
section as well, near line 260 ?
> and
>
> Tested-by: Greg Kurz <groug@kaod.org>
>
> Whose tree is this going through BTW ?
>
> > .travis.yml | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/.travis.yml b/.travis.yml
> > index 92b00927d4..1d46442020 100644
> > --- a/.travis.yml
> > +++ b/.travis.yml
> > @@ -15,6 +15,7 @@ addons:
> > - libaio-dev
> > - libattr1-dev
> > - libbrlapi-dev
> > + - libcap-dev
> > - libcap-ng-dev
> > - libgcc-4.8-dev
> > - libgnutls-dev
>
next prev parent reply other threads:[~2019-09-05 12:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 11:33 [Qemu-devel] [PATCH] travis.yml: Install libcap-dev for testing virito-9p Thomas Huth
2019-09-05 11:41 ` Philippe Mathieu-Daudé
2019-09-05 12:07 ` Greg Kurz
2019-09-05 12:18 ` Greg Kurz [this message]
2019-09-06 11:22 ` Thomas Huth
2019-09-06 11:25 ` Thomas Huth
2019-09-06 12:05 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190905141848.331aba6c@bahia.lan \
--to=groug@kaod.org \
--cc=alex.bennee@linaro.org \
--cc=fam@euphon.net \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).