From: Greg Kurz <groug@kaod.org>
To: Thomas Huth <thuth@redhat.com>
Cc: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] gitlab-ci.yml: Install libattr1-dev and libcap-dev to test virtio-9p
Date: Thu, 5 Sep 2019 14:21:20 +0200 [thread overview]
Message-ID: <20190905142120.1edb7895@bahia.lan> (raw)
In-Reply-To: <20190905111729.1197-1-thuth@redhat.com>
On Thu, 5 Sep 2019 13:17:29 +0200
Thomas Huth <thuth@redhat.com> wrote:
> So far the gitlab-ci was not testing virtio-9p yet, since we did not
> install libattr1-dev and libcap-dev in any of the pipelines. Do it
> now to get some more test coverage.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> .gitlab-ci.yml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index cd4c03372b..ed8067f5cf 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -59,7 +59,7 @@ build-user:
>
> build-clang:
> script:
> - - apt-get install -y -qq clang libsdl2-dev
> + - apt-get install -y -qq clang libsdl2-dev libattr1-dev libcap-dev
> xfslibs-dev libiscsi-dev libnfs-dev libseccomp-dev gnutls-dev librbd-dev
> - ./configure --cc=clang --cxx=clang++ --enable-werror
> --target-list="alpha-softmmu arm-softmmu m68k-softmmu mips64-softmmu
I don't know gitlab-ci at all but shouldn't these libs be added to some
other builds as well ?
Apart from that, this change looks okay so:
Acked-by: Greg Kurz <groug@kaod.org>
next prev parent reply other threads:[~2019-09-05 12:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 11:17 [Qemu-devel] [PATCH] gitlab-ci.yml: Install libattr1-dev and libcap-dev to test virtio-9p Thomas Huth
2019-09-05 12:21 ` Greg Kurz [this message]
2019-09-05 13:57 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190905142120.1edb7895@bahia.lan \
--to=groug@kaod.org \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).