From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACB6CC43331 for ; Thu, 5 Sep 2019 15:28:46 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1C98B206B8 for ; Thu, 5 Sep 2019 15:28:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1C98B206B8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47316 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i5tgj-0007gl-Kv for qemu-devel@archiver.kernel.org; Thu, 05 Sep 2019 11:28:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43429) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i5tcp-0003aA-Au for qemu-devel@nongnu.org; Thu, 05 Sep 2019 11:24:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i5tcn-0008VL-DQ for qemu-devel@nongnu.org; Thu, 05 Sep 2019 11:24:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53156) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i5tcn-0008VD-5U for qemu-devel@nongnu.org; Thu, 05 Sep 2019 11:24:41 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 56444C05168C; Thu, 5 Sep 2019 15:24:40 +0000 (UTC) Received: from localhost.localdomain (ovpn-123-245.rdu2.redhat.com [10.10.123.245]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 48D785C1D4; Thu, 5 Sep 2019 15:24:39 +0000 (UTC) Date: Thu, 5 Sep 2019 11:24:37 -0400 From: Cleber Rosa To: Eduardo Habkost Message-ID: <20190905152437.GA15321@localhost.localdomain> References: <20190829013125.GG16342@umbus.fritz.box> <20190830175648.GE3694@habkost.net> <20190831014834.GC12065@umbus.fritz.box> <20190904195717.GA2311@localhost.localdomain> <20190905020924.GB2120@umbus.fritz.box> <20190905133824.GA12364@localhost.localdomain> <20190905140618.GE4617@habkost.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190905140618.GE4617@habkost.net> User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 05 Sep 2019 15:24:40 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] Cryptic errors from PIP install if missing openssl-devel X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ldoktor@redhat.com, qemu-devel@nongnu.org, David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Sep 05, 2019 at 11:06:18AM -0300, Eduardo Habkost wrote: > On Thu, Sep 05, 2019 at 09:38:24AM -0400, Cleber Rosa wrote: > > On Thu, Sep 05, 2019 at 12:09:24PM +1000, David Gibson wrote: > > > On Wed, Sep 04, 2019 at 03:57:17PM -0400, Cleber Rosa wrote: > > > > > > > > Hi David, > > > > > > > > I've pushed a branch here (most of the commits have already been sent > > > > separately): > > > > > > > > https://github.com/clebergnu/qemu/tree/ppc64 > > > > > > > > I've tested on a RHEL 8 ppc64le Power 9, and it seems to work for me. > > > > My steps for building QEMU: > > > > > > > > - Configured with: '/home/cleber/src/qemu/configure' '--enable-slirp=git' '--python=/usr/bin/python3' '--target-list=x86_64-softmmu,ppc64-softmmu,arm-softmmu,aarch64-softmmu,mips-softmmu,mipsel-softmmu,mips64-softmmu,mips64el-softmmu,sh4-softmmu,s390x-softmmu,alpha-softmmu,m68k-softmmu,riscv64-softmmu' > > > > - make > > > > - make check-acceptance > > > > > > > > Would you be able to test if that branch works smoothly for you? > > > > > > So, with this tree I'm no longer getting problems if openssl-devel is > > > not installed, so that much looks good. > > > > > > I am getting some different errors - I was seeing this before (with > > > openssl-devel installed) sometimes, but only sometimes. I haven't yet > > > worked out a pattern for when they appeared. They also don't appear > > > to be fatal, the rest of the tests seem to be running ok. Any ideas? > > > > > > VENV /home/dwg/qemu/build/rhel8/tests/venv > > > PIP /home/dwg/qemu/tests/requirements.txt > > > AVOCADO tests/acceptance > > > Error running method "run" of plugin "html": 'Namespace' object has no attribute 'get' > > > Error running method "run" of plugin "varianter_cit": 'Namespace' object has no attribute 'get' > > > > Hi David, > > > > Yes, those should not be fatal. Anyway, they are caused by two things: > > > > 1) A second set of Avocado plugins installation with different versions > > than the Avocado installation on QEMU's tests venv > > > > 2) The tests' venv, which is created with "--system-site-packages", > > option that is described as "Give the virtual environment access > > to the system site-packages dir." > > > > The motivation to have "--system-site-packages" is that, if the user > > had any of the "requirements.txt" depedencies installed system wide, > > the venv would simply use it and skip downloads. Maybe we should make > > that an optional feature, disabled by default, so that the test's venv > > is better isolated and more predictable by default. > > > > Eduardo, > > > > I remember we discussed #2, so your opinion is appreciated here. > > I think I was the person who insisted for --system-site-packages. > Considering that we're often using very recent versions of > Avocado, maybe trying to use system-provided Avocado modules by > default wasn't a good idea after all. > > Making --system-site-packages optional and not enabling it by > default sounds like a reasonable workaround. > OK, agreed. FIY, given the fact that pip itself keeps a local cache, not using "--system-site-packages" this shouldn't be much of a hit when it comes to downloads. Cheers, - Cleber. > -- > Eduardo >