* [Qemu-devel] [PATCH] tests/Makefile: test-char does not need libqtest
@ 2019-09-06 15:26 Thomas Huth
2019-09-09 16:39 ` John Snow
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Huth @ 2019-09-06 15:26 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Marc-André Lureau, Paolo Bonzini
No need to link the libqtest objects here.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/Makefile.include | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/Makefile.include b/tests/Makefile.include
index a35431ca0a..7ee2f9cb5d 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -525,7 +525,7 @@ tests/check-qlit$(EXESUF): tests/check-qlit.o $(test-util-obj-y)
tests/check-qom-interface$(EXESUF): tests/check-qom-interface.o $(test-qom-obj-y)
tests/check-qom-proplist$(EXESUF): tests/check-qom-proplist.o $(test-qom-obj-y)
-tests/test-char$(EXESUF): tests/test-char.o $(test-util-obj-y) $(qtest-obj-y) $(test-io-obj-y) $(chardev-obj-y) tests/socket-helpers.o
+tests/test-char$(EXESUF): tests/test-char.o $(test-util-obj-y) $(test-io-obj-y) $(chardev-obj-y) tests/socket-helpers.o
tests/test-coroutine$(EXESUF): tests/test-coroutine.o $(test-block-obj-y)
tests/test-aio$(EXESUF): tests/test-aio.o $(test-block-obj-y)
tests/test-aio-multithread$(EXESUF): tests/test-aio-multithread.o $(test-block-obj-y)
--
2.18.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] tests/Makefile: test-char does not need libqtest
2019-09-06 15:26 [Qemu-devel] [PATCH] tests/Makefile: test-char does not need libqtest Thomas Huth
@ 2019-09-09 16:39 ` John Snow
0 siblings, 0 replies; 2+ messages in thread
From: John Snow @ 2019-09-09 16:39 UTC (permalink / raw)
To: Thomas Huth, qemu-devel
Cc: qemu-trivial, Marc-André Lureau, Paolo Bonzini
On 9/6/19 11:26 AM, Thomas Huth wrote:
> No need to link the libqtest objects here.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
> ---
> tests/Makefile.include | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index a35431ca0a..7ee2f9cb5d 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -525,7 +525,7 @@ tests/check-qlit$(EXESUF): tests/check-qlit.o $(test-util-obj-y)
> tests/check-qom-interface$(EXESUF): tests/check-qom-interface.o $(test-qom-obj-y)
> tests/check-qom-proplist$(EXESUF): tests/check-qom-proplist.o $(test-qom-obj-y)
>
> -tests/test-char$(EXESUF): tests/test-char.o $(test-util-obj-y) $(qtest-obj-y) $(test-io-obj-y) $(chardev-obj-y) tests/socket-helpers.o
> +tests/test-char$(EXESUF): tests/test-char.o $(test-util-obj-y) $(test-io-obj-y) $(chardev-obj-y) tests/socket-helpers.o
> tests/test-coroutine$(EXESUF): tests/test-coroutine.o $(test-block-obj-y)
> tests/test-aio$(EXESUF): tests/test-aio.o $(test-block-obj-y)
> tests/test-aio-multithread$(EXESUF): tests/test-aio-multithread.o $(test-block-obj-y)
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-09 16:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-06 15:26 [Qemu-devel] [PATCH] tests/Makefile: test-char does not need libqtest Thomas Huth
2019-09-09 16:39 ` John Snow
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).