* [Qemu-devel] [PATCH] linux-user: drop redundant handling of environment variables
@ 2019-09-06 16:57 Max Filippov
2019-09-06 20:56 ` Laurent Vivier
2019-09-10 8:26 ` Laurent Vivier
0 siblings, 2 replies; 3+ messages in thread
From: Max Filippov @ 2019-09-06 16:57 UTC (permalink / raw)
To: qemu-devel; +Cc: Max Filippov, Laurent Vivier
QEMU_STRACE and QEMU_RAND_SEED are handled by the parse_args, no need to
do it again in main.
Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
---
linux-user/main.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/linux-user/main.c b/linux-user/main.c
index c9d97d2b1fc6..22ae2b3e65d1 100644
--- a/linux-user/main.c
+++ b/linux-user/main.c
@@ -701,13 +701,6 @@ int main(int argc, char **argv, char **envp)
thread_cpu = cpu;
- if (getenv("QEMU_STRACE")) {
- do_strace = 1;
- }
-
- if (seed_optarg == NULL) {
- seed_optarg = getenv("QEMU_RAND_SEED");
- }
{
Error *err = NULL;
if (seed_optarg != NULL) {
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] linux-user: drop redundant handling of environment variables
2019-09-06 16:57 [Qemu-devel] [PATCH] linux-user: drop redundant handling of environment variables Max Filippov
@ 2019-09-06 20:56 ` Laurent Vivier
2019-09-10 8:26 ` Laurent Vivier
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Vivier @ 2019-09-06 20:56 UTC (permalink / raw)
To: Max Filippov, qemu-devel
Le 06/09/2019 à 18:57, Max Filippov a écrit :
> QEMU_STRACE and QEMU_RAND_SEED are handled by the parse_args, no need to
> do it again in main.
>
> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
> ---
> linux-user/main.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/linux-user/main.c b/linux-user/main.c
> index c9d97d2b1fc6..22ae2b3e65d1 100644
> --- a/linux-user/main.c
> +++ b/linux-user/main.c
> @@ -701,13 +701,6 @@ int main(int argc, char **argv, char **envp)
>
> thread_cpu = cpu;
>
> - if (getenv("QEMU_STRACE")) {
> - do_strace = 1;
> - }
> -
> - if (seed_optarg == NULL) {
> - seed_optarg = getenv("QEMU_RAND_SEED");
> - }
> {
> Error *err = NULL;
> if (seed_optarg != NULL) {
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] linux-user: drop redundant handling of environment variables
2019-09-06 16:57 [Qemu-devel] [PATCH] linux-user: drop redundant handling of environment variables Max Filippov
2019-09-06 20:56 ` Laurent Vivier
@ 2019-09-10 8:26 ` Laurent Vivier
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Vivier @ 2019-09-10 8:26 UTC (permalink / raw)
To: Max Filippov, qemu-devel
Le 06/09/2019 à 18:57, Max Filippov a écrit :
> QEMU_STRACE and QEMU_RAND_SEED are handled by the parse_args, no need to
> do it again in main.
>
> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
> ---
> linux-user/main.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/linux-user/main.c b/linux-user/main.c
> index c9d97d2b1fc6..22ae2b3e65d1 100644
> --- a/linux-user/main.c
> +++ b/linux-user/main.c
> @@ -701,13 +701,6 @@ int main(int argc, char **argv, char **envp)
>
> thread_cpu = cpu;
>
> - if (getenv("QEMU_STRACE")) {
> - do_strace = 1;
> - }
> -
> - if (seed_optarg == NULL) {
> - seed_optarg = getenv("QEMU_RAND_SEED");
> - }
> {
> Error *err = NULL;
> if (seed_optarg != NULL) {
>
Applied to my linux-user branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-10 8:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-06 16:57 [Qemu-devel] [PATCH] linux-user: drop redundant handling of environment variables Max Filippov
2019-09-06 20:56 ` Laurent Vivier
2019-09-10 8:26 ` Laurent Vivier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).