From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CA6CC49ED6 for ; Wed, 11 Sep 2019 17:19:15 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 11D272053B for ; Wed, 11 Sep 2019 17:19:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 11D272053B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54050 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i86Gw-00082z-9G for qemu-devel@archiver.kernel.org; Wed, 11 Sep 2019 13:19:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48616) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i86GF-0007Zz-SK for qemu-devel@nongnu.org; Wed, 11 Sep 2019 13:18:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i86GE-00018l-EU for qemu-devel@nongnu.org; Wed, 11 Sep 2019 13:18:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56940) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i86GE-00018U-79 for qemu-devel@nongnu.org; Wed, 11 Sep 2019 13:18:30 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8188A10C0937 for ; Wed, 11 Sep 2019 17:18:29 +0000 (UTC) Received: from work-vm (ovpn-117-243.ams2.redhat.com [10.36.117.243]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 75CDF6031D; Wed, 11 Sep 2019 17:18:28 +0000 (UTC) Date: Wed, 11 Sep 2019 18:18:26 +0100 From: "Dr. David Alan Gilbert" To: Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= Message-ID: <20190911171826.GK2894@work-vm> References: <20190911164202.31136-1-dgilbert@redhat.com> <20190911164202.31136-2-dgilbert@redhat.com> <20190911165627.GG24295@redhat.com> <20190911170423.GH2894@work-vm> <20190911170933.GJ24295@redhat.com> <20190911171028.GI2894@work-vm> <20190911171614.GK24295@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20190911171614.GK24295@redhat.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.66]); Wed, 11 Sep 2019 17:18:29 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH 1/3] rcu: Add automatically released rcu_read_lock variant X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, quintela@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Daniel P. Berrang=E9 (berrange@redhat.com) wrote: > On Wed, Sep 11, 2019 at 06:10:28PM +0100, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrang=E9 (berrange@redhat.com) wrote: > > > On Wed, Sep 11, 2019 at 06:04:23PM +0100, Dr. David Alan Gilbert wr= ote: > > > > * Daniel P. Berrang=E9 (berrange@redhat.com) wrote: > > > > > On Wed, Sep 11, 2019 at 05:42:00PM +0100, Dr. David Alan Gilber= t (git) wrote: > > > > > > From: "Dr. David Alan Gilbert" > > > > > >=20 > > > > > > RCU_READ_LOCK_AUTO takes the rcu_read_lock and then uses gli= b's > > > > > > g_auto infrastrcture (and thus whatever the compilers hooks a= re) to > > > > > > release it on all exits of the block. > > > > > >=20 > > > > > > Note this macro has a variable declaration in, and hence is n= ot in > > > > > > a while loop. > > > > > >=20 > > > > > > Signed-off-by: Dr. David Alan Gilbert > > > > > > --- > > > > > > include/qemu/rcu.h | 12 ++++++++++++ > > > > > > 1 file changed, 12 insertions(+) > > > > > >=20 > > > > > > diff --git a/include/qemu/rcu.h b/include/qemu/rcu.h > > > > > > index 22876d1428..6a25b27d28 100644 > > > > > > --- a/include/qemu/rcu.h > > > > > > +++ b/include/qemu/rcu.h > > > > > > @@ -154,6 +154,18 @@ extern void call_rcu1(struct rcu_head *h= ead, RCUCBFunc *func); > > > > > > }), = \ > > > > > > (RCUCBFunc *)g_free); > > > > > > =20 > > > > > > +typedef char rcu_read_auto_t; > > > > > > +static inline void rcu_read_auto_unlock(rcu_read_auto_t *r) > > > > > > +{ > > > > > > + rcu_read_unlock(); > > > > > > +} > > > > > > + > > > > > > +G_DEFINE_AUTO_CLEANUP_CLEAR_FUNC(rcu_read_auto_t, rcu_read_a= uto_unlock) > > > > > > > > > > > > +#define RCU_READ_LOCK_AUTO g_auto(rcu_read_auto_t) \ > > > > > > + _rcu_read_auto =3D 'x'; \ > > > > > > + rcu_read_lock(); > > > > > > + > > > > >=20 > > > > > Functionally this works, but my gut feeling would be to follow > > > > > the design of GMutexLocker as-is: > > > > >=20 > > > > > https://developer.gnome.org/glib/stable/glib-Threads.html#g-m= utex-locker-new > > > > >=20 > > > > > so you get a use pattern of > > > > >=20 > > > > > g_autoptr(rcu_read_locker) locker =3D rcu_read_locker_new(); > > > > >=20 > > > > > This makes it explicit that the code is creating a variable her= e, which > > > > > in turns means it is clear to force unlock early with > > > > >=20 > > > > > g_clear_pointer(&locker, rcu_read_locker_free) > > > >=20 > > > > The difference compared to the g-mutex-locker is that I don't hav= e > > > > another object to use as my pointer; that uses the address of the= GMutex > > > > as the dummy pointer value. I did try an experiment with g_autop= tr > > > > and found that it did need to return a non-NULL value for it to w= ork, > > > > which then lead me to think what value to use - while it seems to= work > > > > if I return (void *)1 it makes me nervous. > > >=20 > > > Yeah, '(void*)1' would have been what I'd pick. The only thing that= the > > > value is used for is to pass to the rcu_read_locker_free() function > > > which ignores it, which seems safe enough. > >=20 > > glib seems to be at least checking it; if you pass NULL the free'r > > doesn't get called; so it worries me that we'd be relying on the curr= ent > > definition. >=20 > This NULL check is part of the API semantics defined for > G_DEFINE_AUTO_CLEANUO_FREE_FUNC. It lets you define > what the "empty" value is, typically 'NULL', but > in fact you don't need to use a pointer type at all. You > can use an 'int', for example, and declare that '-1' > is your "empty" value: >=20 > https://developer.gnome.org/glib/stable/glib-Miscellaneous-Macros.htm= l#G-DEFINE-AUTO-CLEANUP-FREE-FUNC:CAPS Ah OK, yep that makes sense; I'll flip it around. Dave >=20 > Regards, > Daniel > --=20 > |: https://berrange.com -o- https://www.flickr.com/photos/dberr= ange :| > |: https://libvirt.org -o- https://fstop138.berrange= .com :| > |: https://entangle-photo.org -o- https://www.instagram.com/dberr= ange :| -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK