From: Stefan Hajnoczi <stefanha@gmail.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: virtio-fs@redhat.com, "Michael S. Tsirkin" <mst@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/4] virtiofsd: add --print-capabilities option
Date: Thu, 12 Sep 2019 13:12:48 +0200 [thread overview]
Message-ID: <20190912111248.GD23174@stefanha-x1.localdomain> (raw)
In-Reply-To: <20190904155121.GA25679@stefanha-x1.localdomain>
[-- Attachment #1: Type: text/plain, Size: 943 bytes --]
On Wed, Sep 04, 2019 at 04:51:21PM +0100, Stefan Hajnoczi wrote:
> On Tue, Sep 03, 2019 at 06:26:44PM +0100, Dr. David Alan Gilbert wrote:
> > * Stefan Hajnoczi (stefanha@redhat.com) wrote:
> > > Add the --print-capabilities option as per vhost-user.rst "Backend
> > > programs conventions". Currently there are no advertised features.
> > >
> > > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> >
> > That looks OK to me, but can someone who understands the json
> > requirement explain what says whether a 'features' entry is optional?
>
> I have defined a VHostUserBackendType ('fs') but no
> VHostUserBackendCapabilities union field.
>
> I guess this is allowed since many other VIRTIO device types are also
> defined without a VHostUserBackendCapabilities union field (only 'gpu'
> and 'input' have one).
Hi Marc-André,
Please review when you have time. You are the vhost-user.json expert
:).
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-09-12 11:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 9:54 [Qemu-devel] [PATCH 0/4] virtiofsd: implement vhost-user.rst "Backend program conventions" Stefan Hajnoczi
2019-08-27 9:54 ` [Qemu-devel] [PATCH 1/4] virtiofsd: make -f (foreground) the default Stefan Hajnoczi
2019-09-03 17:17 ` Dr. David Alan Gilbert
2019-08-27 9:54 ` [Qemu-devel] [PATCH 2/4] virtiofsd: add --print-capabilities option Stefan Hajnoczi
2019-09-03 17:26 ` Dr. David Alan Gilbert
2019-09-04 15:51 ` Stefan Hajnoczi
2019-09-12 11:12 ` Stefan Hajnoczi [this message]
2019-09-12 12:40 ` Marc-André Lureau
2019-08-27 9:54 ` [Qemu-devel] [PATCH 3/4] virtiofsd: install virtiofsd in libexec Stefan Hajnoczi
2019-09-03 17:29 ` Dr. David Alan Gilbert
2019-08-27 9:54 ` [Qemu-devel] [PATCH 4/4] virtiofsd: add vhost-user.json file Stefan Hajnoczi
2019-09-03 17:31 ` Dr. David Alan Gilbert
2019-09-03 17:32 ` [Qemu-devel] [PATCH 0/4] virtiofsd: implement vhost-user.rst "Backend program conventions" Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190912111248.GD23174@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=dgilbert@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).