Re: [Qemu-devel] [RFC v3 PATCH 05/45] multi-process: Add config option for multi-process QEMU

[Stefan Hajnoczi <stefanha@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1154 bytes --]

On Tue, Sep 03, 2019 at 04:37:31PM -0400, Jagannathan Raman wrote:
> @@ -1543,6 +1544,10 @@ for opt do
>    ;;
>    --disable-libpmem) libpmem=no
>    ;;
> +  --enable-mpqemu) mpqemu=yes
> +  ;;
> +  --disable-mpqemu) mpqemu=no

A previous patch used "remote" instead of "mpqemu", which is confusing.

"mpqemu" seems reasonable.  "remote" is too generic.  Can you use
"mpqemu" everywhere?

> +  ;;
>    *)
>        echo "ERROR: unknown option $opt"
>        echo "Try '$0 --help' for more information"
> @@ -1842,6 +1847,7 @@ disabled with --disable-FEATURE, default is enabled if available:
>    capstone        capstone disassembler support
>    debug-mutex     mutex debugging support
>    libpmem         libpmem support
> +  mpqemu          multi-process QEMU support
>  
>  NOTE: The object files are built at the place where configure is launched
>  EOF
> @@ -6481,6 +6487,7 @@ echo "docker            $docker"
>  echo "libpmem support   $libpmem"
>  echo "libudev           $libudev"
>  echo "default devices   $default_devices"
> +echo "multiprocess QEMU $mpqemu"

multi-process (see above) or multiprocess? :-)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]