From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D13B9C4CEC6 for ; Thu, 12 Sep 2019 16:20:39 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A332F2084D for ; Thu, 12 Sep 2019 16:20:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A332F2084D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36892 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i8Rpm-0002oL-SE for qemu-devel@archiver.kernel.org; Thu, 12 Sep 2019 12:20:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54207) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i8RoP-00028q-Kp for qemu-devel@nongnu.org; Thu, 12 Sep 2019 12:19:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i8RoN-0003nv-FN for qemu-devel@nongnu.org; Thu, 12 Sep 2019 12:19:13 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:9652 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i8RoM-0003jS-Rc for qemu-devel@nongnu.org; Thu, 12 Sep 2019 12:19:11 -0400 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x8CGHRCG101179 for ; Thu, 12 Sep 2019 12:19:03 -0400 Received: from e06smtp04.uk.ibm.com (e06smtp04.uk.ibm.com [195.75.94.100]) by mx0b-001b2d01.pphosted.com with ESMTP id 2uyqxhv48s-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 12 Sep 2019 12:19:03 -0400 Received: from localhost by e06smtp04.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 12 Sep 2019 17:19:01 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp04.uk.ibm.com (192.168.101.134) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 12 Sep 2019 17:18:57 +0100 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x8CGIvCc34996314 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 12 Sep 2019 16:18:57 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F1C005204E; Thu, 12 Sep 2019 16:18:56 +0000 (GMT) Received: from oc2783563651 (unknown [9.152.224.202]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id B6F7C52052; Thu, 12 Sep 2019 16:18:56 +0000 (GMT) Date: Thu, 12 Sep 2019 18:18:55 +0200 From: Halil Pasic To: =?UTF-8?B?TWFyYy1BbmRyw6k=?= Lureau In-Reply-To: <20190912122514.22504-4-marcandre.lureau@redhat.com> References: <20190912122514.22504-1-marcandre.lureau@redhat.com> <20190912122514.22504-4-marcandre.lureau@redhat.com> Organization: IBM X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-TM-AS-GCONF: 00 x-cbid: 19091216-0016-0000-0000-000002AA7A4D X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19091216-0017-0000-0000-0000330B0D06 Message-Id: <20190912181855.54f20a7e.pasic@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-09-12_08:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1909120169 Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by mx0b-001b2d01.pphosted.com id x8CGHRCG101179 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 148.163.158.5 Subject: Re: [Qemu-devel] [PATCH v3 3/6] vmstate: replace DeviceState with VMStateIf X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: berrange@redhat.com, quintela@redhat.com, mprivozn@redhat.com, qemu-devel@nongnu.org, dgilbert@redhat.com, pbonzini@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, 12 Sep 2019 16:25:11 +0400 Marc-Andr=C3=A9 Lureau wrote: > diff --git a/hw/s390x/s390-skeys.c b/hw/s390x/s390-skeys.c > index d4807f7777..16b9bbf04d 100644 > --- a/hw/s390x/s390-skeys.c > +++ b/hw/s390x/s390-skeys.c > @@ -392,7 +392,7 @@ static inline void s390_skeys_set_migration_enabled= (Object *obj, bool value, > register_savevm_live(NULL, TYPE_S390_SKEYS, 0, 1, > &savevm_s390_storage_keys, ss); > } else { > - unregister_savevm(DEVICE(ss), TYPE_S390_SKEYS, ss); > + unregister_savevm(VMSTATE_IF(ss), TYPE_S390_SKEYS, ss); > } > } Acked-by: Halil Pasic BTW what does the 'f' in VMStateIf stand for? (I've had a look at 2/6 but didn't figure out the answer). Regards, Halil