From: Maxim Levitsky <mlevitsk@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Vladimir Sementsov-Ogievskiy" <vsementsov@virtuozzo.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
qemu-block@nongnu.org, qemu-stable <qemu-stable@nongnu.org>,
"Max Reitz" <mreitz@redhat.com>,
"Maxim Levitsky" <mlevitsk@redhat.com>
Subject: [Qemu-devel] [PATCH v5 0/3] Fix qcow2+luks corruption introduced by commit 8ac0f15f335
Date: Fri, 13 Sep 2019 18:28:15 +0300 [thread overview]
Message-ID: <20190913152818.17843-1-mlevitsk@redhat.com> (raw)
Commit 8ac0f15f335 accidently broke the COW of non changed areas
of newly allocated clusters, when the write spans multiple clusters,
and needs COW both prior and after the write.
This results in 'after' COW area being encrypted with wrong
sector address, which render it corrupted.
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1745922
CC: qemu-stable <qemu-stable@nongnu.org>
V2: grammar, spelling and code style fixes.
V3: more fixes after the review.
V4: addressed review comments from Max Reitz,
and futher refactored the qcow2_co_encrypt to just take full host and guest offset
which simplifies everything.
V5: reworked the patches so one of them fixes the bug
only and other one is just refactoring
Best regards,
Maxim Levitsky
Maxim Levitsky (3):
Fix qcow2+luks corruption introduced by commit 8ac0f15f335
block/qcow2: refactor threaded encryption code
qemu-iotests: Add test for bz #1745922
block/qcow2-cluster.c | 29 +++++++-----
block/qcow2-threads.c | 62 ++++++++++++++++++++------
block/qcow2.c | 5 ++-
block/qcow2.h | 8 ++--
tests/qemu-iotests/263 | 91 ++++++++++++++++++++++++++++++++++++++
tests/qemu-iotests/263.out | 40 +++++++++++++++++
tests/qemu-iotests/group | 2 +
7 files changed, 206 insertions(+), 31 deletions(-)
create mode 100755 tests/qemu-iotests/263
create mode 100644 tests/qemu-iotests/263.out
--
2.17.2
next reply other threads:[~2019-09-13 15:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-13 15:28 Maxim Levitsky [this message]
2019-09-13 15:28 ` [Qemu-devel] [PATCH v5 1/3] Fix qcow2+luks corruption introduced by commit 8ac0f15f335 Maxim Levitsky
2019-09-13 15:44 ` Vladimir Sementsov-Ogievskiy
2019-09-13 15:28 ` [Qemu-devel] [PATCH v5 2/3] block/qcow2: refactor threaded encryption code Maxim Levitsky
2019-09-13 16:11 ` Vladimir Sementsov-Ogievskiy
2019-09-13 16:27 ` Maxim Levitsky
2019-09-13 15:28 ` [Qemu-devel] [PATCH v5 3/3] qemu-iotests: Add test for bz #1745922 Maxim Levitsky
2019-09-13 16:27 ` Vladimir Sementsov-Ogievskiy
2019-09-13 16:39 ` Maxim Levitsky
2019-09-13 16:57 ` Vladimir Sementsov-Ogievskiy
2019-09-13 17:03 ` Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190913152818.17843-1-mlevitsk@redhat.com \
--to=mlevitsk@redhat.com \
--cc=berrange@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).