qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-ppc@nongnu.org, "Riku Voipio" <riku.voipio@iki.fi>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	qemu-devel@nongnu.org, rth@twiddle.net
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH] target/ppc: fix signal delivery for ppc64abi32
Date: Mon, 16 Sep 2019 11:48:58 +1000	[thread overview]
Message-ID: <20190916014858.GH2104@umbus.fritz.box> (raw)
In-Reply-To: <8f76ef47-0cf8-c662-0100-d416f5f2e0c1@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 1108 bytes --]

On Wed, Sep 11, 2019 at 10:33:45AM -0400, Richard Henderson wrote:
> On 9/11/19 5:39 AM, Alex Bennée wrote:
> > We were incorrectly setting NIP resulting in a segfault. This fixes
> > linux-test for this ABI.
> 
> Perhaps better:
> We were incorrectly using the 64-bit AIX ABI instead of the 32-bit SYSV ABI for
> setting NIP for the signal handler.

Applied to ppc-for-4.2, with Richard's updated description.

For future reference, it's better to directly CC me on such patches.
I only barely keep on top of the mailing lists, so if you just send it
there it's likely to be some time before I pick it up, or even get
lost entirely.

> 
> ?
> 
> > 
> > Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> > ---
> >  linux-user/ppc/signal.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> Anyway,
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> 

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2019-09-16  5:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-11  9:39 [Qemu-devel] [PATCH] target/ppc: fix signal delivery for ppc64abi32 Alex Bennée
2019-09-11 14:33 ` Richard Henderson
2019-09-16  1:48   ` David Gibson [this message]
2019-09-16  7:22     ` [Qemu-devel] [Qemu-ppc] " Alex Bennée
2019-09-17  2:03       ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190916014858.GH2104@umbus.fritz.box \
    --to=david@gibson.dropbear.id.au \
    --cc=alex.bennee@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=riku.voipio@iki.fi \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).