From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Alex Williamson" <alex.williamson@redhat.com>,
peterx@redhat.com, "Eric Auger" <eric.auger@redhat.com>,
"Bandan Das" <bsd@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Richard Henderson" <rth@twiddle.net>
Subject: [Qemu-devel] [PATCH v3 4/4] intel_iommu: Remove the caching-mode check during flag change
Date: Mon, 16 Sep 2019 16:07:18 +0800 [thread overview]
Message-ID: <20190916080718.3299-5-peterx@redhat.com> (raw)
In-Reply-To: <20190916080718.3299-1-peterx@redhat.com>
That's never a good place to stop QEMU process... Since now we have
both the machine done sanity check and also the hotplug handler, we
can safely remove this to avoid that.
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
---
hw/i386/intel_iommu.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
index bed8ffe446..f1de8fdb75 100644
--- a/hw/i386/intel_iommu.c
+++ b/hw/i386/intel_iommu.c
@@ -2936,10 +2936,6 @@ static void vtd_iommu_notify_flag_changed(IOMMUMemoryRegion *iommu,
VTDAddressSpace *vtd_as = container_of(iommu, VTDAddressSpace, iommu);
IntelIOMMUState *s = vtd_as->iommu_state;
- if (!s->caching_mode && new & IOMMU_NOTIFIER_MAP) {
- vtd_panic_require_caching_mode();
- }
-
/* Update per-address-space notifier flags */
vtd_as->notifier_flags = new;
--
2.21.0
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Eduardo Habkost <ehabkost@redhat.com>,
Peter Xu <peterx@redhat.com>, Eric Auger <eric.auger@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: [Qemu-devel] [PULL 08/10] intel_iommu: Remove the caching-mode check during flag change
Date: Tue, 17 Sep 2019 11:11:08 -0400 [thread overview]
Message-ID: <20190916080718.3299-5-peterx@redhat.com> (raw)
Message-ID: <20190917151108.Y3vOLwJjXsdEj8BX1LhMqzskf_-8DbPFkgd6Ma8uL7o@z> (raw)
In-Reply-To: <20190917151011.24588-1-mst@redhat.com>
From: Peter Xu <peterx@redhat.com>
That's never a good place to stop QEMU process... Since now we have
both the machine done sanity check and also the hotplug handler, we
can safely remove this to avoid that.
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
Message-Id: <20190916080718.3299-5-peterx@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/i386/intel_iommu.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
index bed8ffe446..f1de8fdb75 100644
--- a/hw/i386/intel_iommu.c
+++ b/hw/i386/intel_iommu.c
@@ -2936,10 +2936,6 @@ static void vtd_iommu_notify_flag_changed(IOMMUMemoryRegion *iommu,
VTDAddressSpace *vtd_as = container_of(iommu, VTDAddressSpace, iommu);
IntelIOMMUState *s = vtd_as->iommu_state;
- if (!s->caching_mode && new & IOMMU_NOTIFIER_MAP) {
- vtd_panic_require_caching_mode();
- }
-
/* Update per-address-space notifier flags */
vtd_as->notifier_flags = new;
--
MST
next prev parent reply other threads:[~2019-09-16 8:11 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-16 8:07 [Qemu-devel] [PATCH v3 0/4] intel_iommu: Do sanity check of vfio-pci earlier Peter Xu
2019-09-16 8:07 ` [Qemu-devel] [PATCH v3 1/4] intel_iommu: Sanity check vfio-pci config on machine init done Peter Xu
2019-09-17 15:10 ` [Qemu-devel] [PULL 05/10] " Michael S. Tsirkin
2019-09-16 8:07 ` [Qemu-devel] [PATCH v3 2/4] qdev/machine: Introduce hotplug_allowed hook Peter Xu
2019-09-17 15:10 ` [Qemu-devel] [PULL 06/10] " Michael S. Tsirkin
2019-09-16 8:07 ` [Qemu-devel] [PATCH v3 3/4] pc/q35: Disallow vfio-pci hotplug without VT-d caching mode Peter Xu
2019-09-17 15:11 ` [Qemu-devel] [PULL 07/10] " Michael S. Tsirkin
2019-09-16 8:07 ` Peter Xu [this message]
2019-09-17 15:11 ` [Qemu-devel] [PULL 08/10] intel_iommu: Remove the caching-mode check during flag change Michael S. Tsirkin
-- strict thread matches above, loose matches on Subject: below --
2019-09-17 15:10 [Qemu-devel] [PULL 00/10] virtio, vhost, pc: features, fixes, cleanups Michael S. Tsirkin
2019-08-01 0:40 ` [Qemu-devel] [PATCH v2] docs/nvdimm: add example on persistent backend setup Wei Yang
2019-08-01 8:05 ` Stefan Hajnoczi
2019-09-11 8:51 ` Wei Yang
2019-09-12 12:16 ` Stefan Hajnoczi
2019-09-12 21:44 ` Wei Yang
2019-09-17 15:10 ` [Qemu-devel] [PULL 02/10] " Michael S. Tsirkin
2019-08-21 12:16 ` [Qemu-devel] [PATCH v3] virtio pmem: user document Pankaj Gupta
2019-08-26 12:46 ` Cornelia Huck
2019-09-16 6:30 ` Pankaj Gupta
2019-09-17 15:11 ` [Qemu-devel] [PULL 09/10] " Michael S. Tsirkin
2019-08-22 18:34 ` [Qemu-devel] [PATCH 1/2] vhost-user-blk: prevent using uninitialized vqs Raphael Norwitz
2019-08-22 18:34 ` [Qemu-devel] [PATCH 2/2] backends/vhost-user.c: " Raphael Norwitz
2019-08-28 8:29 ` Stefan Hajnoczi
2019-09-17 15:10 ` [Qemu-devel] [PULL 04/10] " Michael S. Tsirkin
2019-08-23 3:43 ` [Qemu-devel] [Qemu-block] [PATCH 1/2] vhost-user-blk: " yuchenlin via Qemu-devel
2019-08-28 8:28 ` [Qemu-devel] " Stefan Hajnoczi
2019-09-17 15:10 ` [Qemu-devel] [PULL 03/10] " Michael S. Tsirkin
2019-09-10 14:03 ` [Qemu-devel] [PATCH v2] MAINTAINERS: update virtio-rng and virtio-serial maintainer Laurent Vivier
2019-09-17 15:10 ` [Qemu-devel] [PULL 01/10] " Michael S. Tsirkin
2019-09-13 12:06 ` [Qemu-devel] [PATCH v3] virtio-mmio: implement modern (v2) personality (virtio-1) Sergio Lopez
2019-09-16 14:40 ` Cornelia Huck
2019-09-17 15:11 ` [Qemu-devel] [PULL 10/10] " Michael S. Tsirkin
2019-09-21 7:06 ` [Qemu-devel] [PATCH v3] virtio-mmio: implement modern (v2), " Vasyl Vavrychuk
2019-09-23 13:58 ` Sergio Lopez
2019-09-19 10:13 ` [Qemu-devel] [PULL 00/10] virtio, vhost, pc: features, fixes, cleanups Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190916080718.3299-5-peterx@redhat.com \
--to=peterx@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=berrange@redhat.com \
--cc=bsd@redhat.com \
--cc=ehabkost@redhat.com \
--cc=eric.auger@redhat.com \
--cc=imammedo@redhat.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).