Re: [Qemu-devel] [PATCH v2] target/s390x/kvm: Officially require at least kernel 3.15

[Cornelia Huck <cohuck@redhat.com>]

On Fri, 13 Sep 2019 11:14:43 +0200
Thomas Huth <thuth@redhat.com> wrote:

Modified the subject, as suggested by David.

> Since QEMU v2.10, the KVM acceleration does not work on older kernels
> anymore since the code accidentally requires the KVM_CAP_DEVICE_CTRL
> capability now - it should have been optional instead.
> Instead of fixing the bug, we asked in the ChangeLog of QEMU 2.11 - 3.0
> that people should speak up if they still need support of QEMU running
> with KVM on older kernels, but seems like nobody really complained.
> Thus let's make this official now and turn it into a proper error
> message, telling the users to use at least kernel 3.15 now.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  v2: Remove also the entry in trace-events
> 
>  hw/intc/s390_flic_kvm.c | 6 ------
>  hw/intc/trace-events    | 1 -
>  target/s390x/kvm.c      | 7 +++++++
>  3 files changed, 7 insertions(+), 7 deletions(-)

(...)

> diff --git a/hw/intc/trace-events b/hw/intc/trace-events
> index 90c9d07c1a..719f46b516 100644
> --- a/hw/intc/trace-events
> +++ b/hw/intc/trace-events
> @@ -75,7 +75,6 @@ xics_ics_simple_eoi(int nr) "ics_eoi: irq 0x%x"
>  
>  # s390_flic_kvm.c
>  flic_create_device(int err) "flic: create device failed %d"
> -flic_no_device_api(int err) "flic: no Device Contral API support %d"

Nice, this also gets rid of a typo :)

>  flic_reset_failed(int err) "flic: reset failed %d"
>  
>  # s390_flic.c

(...)

Thanks, applied.