qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: peter.maydell@linaro.org
Cc: "Fam Zheng" <fam@euphon.net>, "John Snow" <jsnow@redhat.com>,
	qemu-devel@nongnu.org,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	qemu-arm@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>
Subject: [Qemu-devel] [PATCH  v1 3/9] podman: fix command invocation
Date: Tue, 17 Sep 2019 19:41:03 +0100	[thread overview]
Message-ID: <20190917184109.12564-4-alex.bennee@linaro.org> (raw)
In-Reply-To: <20190917184109.12564-1-alex.bennee@linaro.org>

From: John Snow <jsnow@redhat.com>

Oops; there's no argv here.

Signed-off-by: John Snow <jsnow@redhat.com>
Message-Id: <20190913193821.17756-1-jsnow@redhat.com>
---
 tests/docker/docker.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/docker/docker.py b/tests/docker/docker.py
index 29613afd489..bc7a470ca2a 100755
--- a/tests/docker/docker.py
+++ b/tests/docker/docker.py
@@ -334,7 +334,7 @@ class Docker(object):
             cmd = [ "-u", str(uid) ] + cmd
             # podman requires a bit more fiddling
             if self._command[0] == "podman":
-                argv.insert(0, '--userns=keep-id')
+                cmd.insert(0, '--userns=keep-id')
 
         ret = self._do_check(["run", "--label",
                              "com.qemu.instance.uuid=" + label] + cmd,
-- 
2.20.1



  parent reply	other threads:[~2019-09-17 18:48 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-17 18:41 [Qemu-devel] [PATCH v1 0/9] testing/next (docker,podman,float) Alex Bennée
2019-09-17 18:41 ` [Qemu-devel] [PATCH v1 1/9] tests/docker: add sanitizers back to clang build Alex Bennée
2019-09-17 18:43   ` John Snow
2019-09-17 18:41 ` [Qemu-devel] [PATCH v1 2/9] tests/docker: fix DOCKER_PARTIAL_IMAGES Alex Bennée
2019-09-17 19:44   ` Philippe Mathieu-Daudé
2019-09-17 18:41 ` Alex Bennée [this message]
2019-09-17 18:41 ` [Qemu-devel] [PATCH v1 4/9] target/ppc: fix signal delivery for ppc64abi32 Alex Bennée
2019-09-17 18:41 ` [Qemu-devel] [PATCH v1 5/9] tests/tcg: clean-up some comments after the de-tangling Alex Bennée
2019-09-17 18:41 ` [Qemu-devel] [PATCH v1 6/9] tests/tcg: re-enable linux-test for ppc64abi32 Alex Bennée
2019-09-17 18:41 ` [Qemu-devel] [PATCH v1 7/9] tests/tcg: add float_madds test to multiarch Alex Bennée
2019-09-17 19:46   ` Richard Henderson
2019-09-17 21:00     ` Alex Bennée
2019-09-17 21:28       ` Richard Henderson
2019-09-18 11:33         ` Alex Bennée
2019-09-18 15:14           ` Richard Henderson
2019-09-17 18:41 ` [Qemu-devel] [PATCH v1 8/9] tests/tcg: add generic version of float_convs Alex Bennée
2019-09-17 19:49   ` Richard Henderson
2019-09-17 20:57     ` Alex Bennée
2019-09-17 21:31       ` Richard Henderson
2019-09-17 18:41 ` [Qemu-devel] [PATCH v1 9/9] tests/tcg: add refs for PPC float_[convs|madds] tests (FAILS TESTS) Alex Bennée
2019-09-18  8:02 ` [Qemu-devel] [PATCH v1 0/9] testing/next (docker, podman, float) no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190917184109.12564-4-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=fam@euphon.net \
    --cc=jsnow@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).