From: David Hildenbrand <david@redhat.com>
To: qemu-devel@nongnu.org
Cc: Thomas Huth <thuth@redhat.com>,
David Hildenbrand <david@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
qemu-s390x@nongnu.org, Richard Henderson <rth@twiddle.net>
Subject: [Qemu-devel] [PULL SUBSYSTEM s390x 01/29] s390x/tcg: Reset exception_index to -1 instead of 0
Date: Wed, 18 Sep 2019 17:28:54 +0200 [thread overview]
Message-ID: <20190918152922.18949-2-david@redhat.com> (raw)
In-Reply-To: <20190918152922.18949-1-david@redhat.com>
We use the marker "-1" for "no exception". s390_cpu_do_interrupt() might
get confused by that.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
target/s390x/mem_helper.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c
index 29fcce426e..39ee9b3175 100644
--- a/target/s390x/mem_helper.c
+++ b/target/s390x/mem_helper.c
@@ -1747,7 +1747,7 @@ uint32_t HELPER(tprot)(CPUS390XState *env, uint64_t a1, uint64_t a2)
if (env->int_pgm_code == PGM_PROTECTION) {
/* retry if reading is possible */
- cs->exception_index = 0;
+ cs->exception_index = -1;
if (!s390_cpu_virt_mem_check_read(cpu, a1, 0, 1)) {
/* Fetching permitted; storing not permitted */
return 1;
@@ -1757,7 +1757,7 @@ uint32_t HELPER(tprot)(CPUS390XState *env, uint64_t a1, uint64_t a2)
switch (env->int_pgm_code) {
case PGM_PROTECTION:
/* Fetching not permitted; storing not permitted */
- cs->exception_index = 0;
+ cs->exception_index = -1;
return 2;
case PGM_ADDRESSING:
case PGM_TRANS_SPEC:
@@ -1767,7 +1767,7 @@ uint32_t HELPER(tprot)(CPUS390XState *env, uint64_t a1, uint64_t a2)
}
/* Translation not available */
- cs->exception_index = 0;
+ cs->exception_index = -1;
return 3;
}
--
2.21.0
next prev parent reply other threads:[~2019-09-18 16:23 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 15:28 [Qemu-devel] [PULL SUBSYSTEM s390x 00/29] s390x/tcg: mem_helper: Fault-safe handling David Hildenbrand
2019-09-18 15:28 ` David Hildenbrand [this message]
2019-09-18 15:28 ` [Qemu-devel] [PULL SUBSYSTEM s390x 02/29] s390x/tcg: MVCL: Zero out unused bits of address David Hildenbrand
2019-09-18 15:28 ` [Qemu-devel] [PULL SUBSYSTEM s390x 03/29] s390x/tcg: MVCL: Detect destructive overlaps David Hildenbrand
2019-09-18 15:28 ` [Qemu-devel] [PULL SUBSYSTEM s390x 04/29] s390x/tcg: MVCL: Process max 4k bytes at a time David Hildenbrand
2019-09-18 15:28 ` [Qemu-devel] [PULL SUBSYSTEM s390x 05/29] s390x/tcg: MVC: Increment the length once David Hildenbrand
2019-09-18 15:28 ` [Qemu-devel] [PULL SUBSYSTEM s390x 06/29] s390x/tcg: MVC: Use is_destructive_overlap() David Hildenbrand
2019-09-18 15:29 ` [Qemu-devel] [PULL SUBSYSTEM s390x 07/29] s390x/tcg: MVPG: Check for specification exceptions David Hildenbrand
2019-09-18 15:29 ` [Qemu-devel] [PULL SUBSYSTEM s390x 08/29] s390x/tcg: MVPG: Properly wrap the addresses David Hildenbrand
2019-09-18 15:29 ` [Qemu-devel] [PULL SUBSYSTEM s390x 09/29] s390x/tcg: MVCLU/MVCLE: Process max 4k bytes at a time David Hildenbrand
2019-09-18 15:29 ` [Qemu-devel] [PULL SUBSYSTEM s390x 10/29] s390x/tcg: MVCS/MVCP: Check for special operation exceptions David Hildenbrand
2019-09-18 15:29 ` [Qemu-devel] [PULL SUBSYSTEM s390x 11/29] s390x/tcg: MVCOS: Lengths are 32 bit in 24/31-bit mode David Hildenbrand
2019-09-18 15:29 ` [Qemu-devel] [PULL SUBSYSTEM s390x 12/29] s390x/tcg: MVCS/MVCP: Properly wrap the length David Hildenbrand
2019-09-18 15:29 ` [Qemu-devel] [PULL SUBSYSTEM s390x 13/29] s390x/tcg: MVST: Check for specification exceptions David Hildenbrand
2019-09-18 15:29 ` [Qemu-devel] [PULL SUBSYSTEM s390x 14/29] s390x/tcg: MVST: Fix storing back the addresses to registers David Hildenbrand
2019-09-18 15:29 ` [Qemu-devel] [PULL SUBSYSTEM s390x 15/29] s390x/tcg: Always use MMU_USER_IDX for CONFIG_USER_ONLY David Hildenbrand
2019-09-18 15:29 ` [Qemu-devel] [PULL SUBSYSTEM s390x 16/29] s390x/tcg: Fault-safe memset David Hildenbrand
2019-09-18 15:29 ` [Qemu-devel] [PULL SUBSYSTEM s390x 17/29] s390x/tcg: Fault-safe memmove David Hildenbrand
2019-09-18 15:29 ` [Qemu-devel] [PULL SUBSYSTEM s390x 18/29] s390x/tcg: MVCS/MVCP: Use access_memmove() David Hildenbrand
2019-09-18 15:29 ` [Qemu-devel] [PULL SUBSYSTEM s390x 19/29] s390x/tcg: MVC: Fault-safe handling on destructive overlaps David Hildenbrand
2019-09-18 15:29 ` [Qemu-devel] [PULL SUBSYSTEM s390x 20/29] s390x/tcg: MVCLU: Fault-safe handling David Hildenbrand
2019-09-18 15:29 ` [Qemu-devel] [PULL SUBSYSTEM s390x 21/29] s390x/tcg: OC: " David Hildenbrand
2019-09-18 15:29 ` [Qemu-devel] [PULL SUBSYSTEM s390x 22/29] s390x/tcg: XC: " David Hildenbrand
2019-09-18 15:29 ` [Qemu-devel] [PULL SUBSYSTEM s390x 23/29] s390x/tcg: NC: " David Hildenbrand
2019-09-18 15:29 ` [Qemu-devel] [PULL SUBSYSTEM s390x 24/29] s390x/tcg: MVCIN: " David Hildenbrand
2019-09-18 15:29 ` [Qemu-devel] [PULL SUBSYSTEM s390x 25/29] s390x/tcg: MVN: " David Hildenbrand
2019-09-18 15:29 ` [Qemu-devel] [PULL SUBSYSTEM s390x 26/29] s390x/tcg: MVZ: " David Hildenbrand
2019-09-18 15:29 ` [Qemu-devel] [PULL SUBSYSTEM s390x 27/29] s390x/tcg: MVST: " David Hildenbrand
2019-09-18 15:29 ` [Qemu-devel] [PULL SUBSYSTEM s390x 28/29] s390x/tcg: MVO: " David Hildenbrand
2019-09-18 15:29 ` [Qemu-devel] [PULL SUBSYSTEM s390x 29/29] tests/tcg: target/s390x: Test MVO David Hildenbrand
2019-09-19 10:00 ` [Qemu-devel] [PULL SUBSYSTEM s390x 00/29] s390x/tcg: mem_helper: Fault-safe handling Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190918152922.18949-2-david@redhat.com \
--to=david@redhat.com \
--cc=cohuck@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).