qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kővágó@redhat.com, Zoltán <DirtY.iCE.hu@gmail.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>
Subject: [Qemu-devel] [PULL 05/26] noaudio: port to the new audio backend api
Date: Thu, 19 Sep 2019 10:36:08 +0200	[thread overview]
Message-ID: <20190919083629.29998-6-kraxel@redhat.com> (raw)
In-Reply-To: <20190919083629.29998-1-kraxel@redhat.com>

From: Kővágó, Zoltán <dirty.ice.hu@gmail.com>

Signed-off-by: Kővágó, Zoltán <DirtY.iCE.hu@gmail.com>
Message-id: 066dc6dd54f4382d80de4376306f585b7fb47805.1568574965.git.DirtY.iCE.hu@gmail.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 audio/noaudio.c | 39 +++++++++++++++------------------------
 1 file changed, 15 insertions(+), 24 deletions(-)

diff --git a/audio/noaudio.c b/audio/noaudio.c
index 0fb2629cf283..b054fd225b66 100644
--- a/audio/noaudio.c
+++ b/audio/noaudio.c
@@ -41,10 +41,9 @@ typedef struct NoVoiceIn {
     int64_t old_ticks;
 } NoVoiceIn;
 
-static size_t no_run_out(HWVoiceOut *hw, size_t live)
+static size_t no_write(HWVoiceOut *hw, void *buf, size_t len)
 {
     NoVoiceOut *no = (NoVoiceOut *) hw;
-    size_t decr, samples;
     int64_t now;
     int64_t ticks;
     int64_t bytes;
@@ -52,13 +51,9 @@ static size_t no_run_out(HWVoiceOut *hw, size_t live)
     now = qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL);
     ticks = now - no->old_ticks;
     bytes = muldiv64(ticks, hw->info.bytes_per_second, NANOSECONDS_PER_SECOND);
-    bytes = MIN(bytes, SIZE_MAX);
-    samples = bytes >> hw->info.shift;
 
     no->old_ticks = now;
-    decr = MIN (live, samples);
-    hw->rpos = (hw->rpos + decr) % hw->samples;
-    return decr;
+    return MIN(len, bytes);
 }
 
 static int no_init_out(HWVoiceOut *hw, struct audsettings *as, void *drv_opaque)
@@ -92,25 +87,21 @@ static void no_fini_in (HWVoiceIn *hw)
     (void) hw;
 }
 
-static size_t no_run_in(HWVoiceIn *hw)
+static size_t no_read(HWVoiceIn *hw, void *buf, size_t size)
 {
+    size_t to_clear;
     NoVoiceIn *no = (NoVoiceIn *) hw;
-    size_t live = audio_pcm_hw_get_live_in(hw);
-    size_t dead = hw->samples - live;
-    size_t samples = 0;
 
-    if (dead) {
-        int64_t now = qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL);
-        int64_t ticks = now - no->old_ticks;
-        int64_t bytes =
-            muldiv64(ticks, hw->info.bytes_per_second, NANOSECONDS_PER_SECOND);
+    int64_t now = qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL);
+    int64_t ticks = now - no->old_ticks;
+    int64_t bytes =
+        muldiv64(ticks, hw->info.bytes_per_second, NANOSECONDS_PER_SECOND);
 
-        no->old_ticks = now;
-        bytes = MIN (bytes, SIZE_MAX);
-        samples = bytes >> hw->info.shift;
-        samples = MIN (samples, dead);
-    }
-    return samples;
+    no->old_ticks = now;
+    to_clear = MIN(bytes, size);
+
+    audio_pcm_info_clear_buf(&hw->info, buf, to_clear >> hw->info.shift);
+    return to_clear;
 }
 
 static int no_ctl_in (HWVoiceIn *hw, int cmd, ...)
@@ -133,12 +124,12 @@ static void no_audio_fini (void *opaque)
 static struct audio_pcm_ops no_pcm_ops = {
     .init_out = no_init_out,
     .fini_out = no_fini_out,
-    .run_out  = no_run_out,
+    .write    = no_write,
     .ctl_out  = no_ctl_out,
 
     .init_in  = no_init_in,
     .fini_in  = no_fini_in,
-    .run_in   = no_run_in,
+    .read     = no_read,
     .ctl_in   = no_ctl_in
 };
 
-- 
2.18.1



  parent reply	other threads:[~2019-09-19  8:41 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-19  8:36 [Qemu-devel] [PULL 00/26] Audio 20190919 patches Gerd Hoffmann
2019-09-19  8:36 ` [Qemu-devel] [PULL 01/26] audio: api for mixeng code free backends Gerd Hoffmann
2019-09-19  8:36 ` [Qemu-devel] [PULL 02/26] alsaaudio: port to the new audio backend api Gerd Hoffmann
2019-09-19  8:36 ` [Qemu-devel] [PULL 03/26] coreaudio: " Gerd Hoffmann
2019-09-19  8:36 ` [Qemu-devel] [PULL 04/26] dsoundaudio: " Gerd Hoffmann
2019-09-19  8:36 ` Gerd Hoffmann [this message]
2019-09-19  8:36 ` [Qemu-devel] [PULL 06/26] ossaudio: " Gerd Hoffmann
2019-09-19  8:36 ` [Qemu-devel] [PULL 07/26] paaudio: " Gerd Hoffmann
2019-09-19  8:36 ` [Qemu-devel] [PULL 08/26] sdlaudio: " Gerd Hoffmann
2019-09-19  8:36 ` [Qemu-devel] [PULL 09/26] spiceaudio: " Gerd Hoffmann
2019-09-19  8:36 ` [Qemu-devel] [PULL 10/26] wavaudio: " Gerd Hoffmann
2019-09-19  8:36 ` [Qemu-devel] [PULL 11/26] audio: remove remains of the old " Gerd Hoffmann
2019-09-19  8:36 ` [Qemu-devel] [PULL 12/26] audio: unify input and output mixeng buffer management Gerd Hoffmann
2019-09-19  8:36 ` [Qemu-devel] [PULL 13/26] audio: common rate control code for timer based outputs Gerd Hoffmann
2019-09-19  8:36 ` [Qemu-devel] [PULL 14/26] audio: split ctl_* functions into enable_* and volume_* Gerd Hoffmann
2019-09-19  8:36 ` [Qemu-devel] [PULL 15/26] audio: add mixeng option (documentation) Gerd Hoffmann
2019-09-19 15:27   ` Eric Blake
2019-09-19  8:36 ` [Qemu-devel] [PULL 16/26] audio: make mixeng optional Gerd Hoffmann
2019-09-19  8:36 ` [Qemu-devel] [PULL 17/26] paaudio: get/put_buffer functions Gerd Hoffmann
2019-09-19  8:36 ` [Qemu-devel] [PULL 18/26] audio: support more than two channels in volume setting Gerd Hoffmann
2019-09-19  8:36 ` [Qemu-devel] [PULL 19/26] audio: replace shift in audio_pcm_info with bytes_per_frame Gerd Hoffmann
2019-09-19  8:36 ` [Qemu-devel] [PULL 20/26] audio: basic support for multichannel audio Gerd Hoffmann
2019-09-19  8:36 ` [Qemu-devel] [PULL 21/26] paaudio: channel-map option Gerd Hoffmann
2019-09-19  8:36 ` [Qemu-devel] [PULL 22/26] usb-audio: do not count on avail bytes actually available Gerd Hoffmann
2019-09-19  8:36 ` [Qemu-devel] [PULL 23/26] usb-audio: support more than two channels of audio Gerd Hoffmann
2019-09-19  8:36 ` [Qemu-devel] [PULL 24/26] usbaudio: change playback counters to 64 bit Gerd Hoffmann
2019-09-19  8:36 ` [Qemu-devel] [PULL 25/26] audio: fix buffer-length typo in documentation Gerd Hoffmann
2019-09-19  8:36 ` [Qemu-devel] [PULL 26/26] audio: fix ALSA period-length " Gerd Hoffmann
2019-09-19 15:15 ` [Qemu-devel] [PULL 00/26] Audio 20190919 patches Peter Maydell
2019-09-19 15:28   ` Eric Blake
2019-09-19 21:26     ` Zoltán Kővágó

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190919083629.29998-6-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=DirtY.iCE.hu@gmail.com \
    --cc=Kővágó@redhat.com \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).